HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37815 )
Change subject: src/*.asl: Add FIXME comment ......................................................................
src/*.asl: Add FIXME comment
A device object must contain either a _HID object or an _ADR object, but should not contain both.
Change-Id: I12acd54679c2c712d5f2a9dce5fb28f4c966eb2b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/northbridge/amd/agesa/family14/acpi/northbridge.asl M src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl M src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl M src/northbridge/amd/pi/00630F01/acpi/northbridge.asl M src/northbridge/amd/pi/00660F01/acpi/northbridge.asl M src/northbridge/amd/pi/00730F01/acpi/northbridge.asl M src/soc/amd/stoneyridge/acpi/northbridge.asl M src/soc/intel/broadwell/acpi/serialio.asl M src/southbridge/intel/lynxpoint/acpi/serialio.asl 12 files changed, 134 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37815/1
diff --git a/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl b/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl index e3f2e5f..2629c3a 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl @@ -18,6 +18,11 @@ /* I/O APIC id 0x3 */ Device(PBIO) { + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ + Name (_HID, "ACPI000A") Name (_ADR, 0x001c0000) } @@ -59,6 +64,10 @@ /* I/O APIC id 0x4 */ Device(PAIO) { + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "ACPI000A") Name (_ADR, 0x001e0000) } diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl index 01942dc..b690d5d 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl @@ -18,6 +18,10 @@ /* Grunt specific I2S machine driver */ Device (I2S) { + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_ADR, 1) Name (_HID, "AMD7219") Name (_CID, "AMD7219") diff --git a/src/mainboard/intel/strago/acpi/mainboard.asl b/src/mainboard/intel/strago/acpi/mainboard.asl index 1d5437b..0318d73 100644 --- a/src/mainboard/intel/strago/acpi/mainboard.asl +++ b/src/mainboard/intel/strago/acpi/mainboard.asl @@ -114,6 +114,11 @@ /* Realtek Audio Codec */ Device (RTEK) /* Audio Codec driver I2C */ { + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_ADR, 0) Name (_HID, AUDIO_CODEC_HID) Name (_CID, AUDIO_CODEC_CID) diff --git a/src/northbridge/amd/agesa/family14/acpi/northbridge.asl b/src/northbridge/amd/agesa/family14/acpi/northbridge.asl index 06199a1..17c569a 100644 --- a/src/northbridge/amd/agesa/family14/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family14/acpi/northbridge.asl @@ -16,6 +16,12 @@ /* Note: Only need HID on Primary Bus */ External (TOM1) External (TOM2) + +/* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ + Name(_HID, EISAID("PNP0A08")) /* PCI Express Root Bridge */ Name(_CID, EISAID("PNP0A03")) /* PCI Root Bridge */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ diff --git a/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl b/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl index 9a1fa9e..bbd8609 100644 --- a/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl @@ -16,6 +16,11 @@ /* Note: Only need HID on Primary Bus */ External (TOM1) External (TOM2) + +/* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name(_HID, EISAID("PNP0A03")) /* PCI Express Root Bridge */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
diff --git a/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl b/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl index f74b31a..9ad0c90 100644 --- a/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl @@ -16,6 +16,11 @@ /* Note: Only need HID on Primary Bus */ External (TOM1) External (TOM2) + +/* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name(_HID, EISAID("PNP0A08")) /* PCI Express Root Bridge */ Name(_CID, EISAID("PNP0A03")) /* PCI Root Bridge */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ diff --git a/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl index c2b3aac..ab3f16c 100644 --- a/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl @@ -16,6 +16,11 @@ /* Note: Only need HID on Primary Bus */ External (TOM1) External (TOM2) + +/* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name(_HID, EISAID("PNP0A03")) /* PCI Express Root Bridge */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
diff --git a/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl index d54f985..fb0e6d1 100644 --- a/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl @@ -16,6 +16,11 @@ /* Note: Only need HID on Primary Bus */ External (TOM1) External (TOM2) + +/* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name(_HID, EISAID("PNP0A08")) /* PCI Express Root Bridge */ Name(_CID, EISAID("PNP0A03")) /* PCI Root Bridge */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ diff --git a/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl index f74b31a..9ad0c90 100644 --- a/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl @@ -16,6 +16,11 @@ /* Note: Only need HID on Primary Bus */ External (TOM1) External (TOM2) + +/* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name(_HID, EISAID("PNP0A08")) /* PCI Express Root Bridge */ Name(_CID, EISAID("PNP0A03")) /* PCI Root Bridge */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ diff --git a/src/soc/amd/stoneyridge/acpi/northbridge.asl b/src/soc/amd/stoneyridge/acpi/northbridge.asl index fe78534..f8d08a6 100644 --- a/src/soc/amd/stoneyridge/acpi/northbridge.asl +++ b/src/soc/amd/stoneyridge/acpi/northbridge.asl @@ -17,6 +17,11 @@ /* Note: Only need HID on Primary Bus */ External (TOM1) External (TOM2) + +/* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name(_HID, EISAID("PNP0A08")) /* PCI Express Root Bridge */ Name(_CID, EISAID("PNP0A03")) /* PCI Root Bridge */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ diff --git a/src/soc/intel/broadwell/acpi/serialio.asl b/src/soc/intel/broadwell/acpi/serialio.asl index 1b44e95..b3dc3e0 100644 --- a/src/soc/intel/broadwell/acpi/serialio.asl +++ b/src/soc/intel/broadwell/acpi/serialio.asl @@ -157,6 +157,11 @@ Device (SDMA) { // Serial IO DMA Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INTL9C60") Name (_UID, 1) Name (_ADR, 0x00150000) @@ -194,6 +199,11 @@ Device (I2C0) { // Serial IO I2C0 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Method (_HID) { If (\ISWP ()) { @@ -265,6 +275,11 @@ Device (I2C1) { // Serial IO I2C1 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Method (_HID) { If (\ISWP ()) { @@ -336,6 +351,11 @@ Device (SPI0) { // Serial IO SPI0 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Method (_HID) { If (\ISWP ()) { @@ -392,6 +412,11 @@ Device (SPI1) { // Serial IO SPI1 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Method (_HID) { If (\ISWP ()) { @@ -460,6 +485,11 @@ Device (UAR0) { // Serial IO UART0 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Method (_HID) { If (\ISWP ()) { @@ -528,6 +558,11 @@ Device (UAR1) { // Serial IO UART1 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Method (_HID) { If (\ISWP ()) { @@ -584,6 +619,11 @@ Device (SDIO) { // Serial IO SDIO Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Method (_HID) { If (\ISWP ()) { diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl index 9323b91..f81ec0b 100644 --- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl @@ -123,6 +123,11 @@ Device (SDMA) { // Serial IO DMA Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INTL9C60") Name (_UID, 1) Name (_ADR, 0x00150000) @@ -160,6 +165,11 @@ Device (I2C0) { // Serial IO I2C0 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INT33C2") Name (_CID, "INT33C2") Name (_UID, 1) @@ -242,6 +252,11 @@ Device (I2C1) { // Serial IO I2C1 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INT33C3") Name (_CID, "INT33C3") Name (_UID, 1) @@ -324,6 +339,11 @@ Device (SPI0) { // Serial IO SPI0 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INT33C0") Name (_CID, "INT33C0") Name (_UID, 1) @@ -362,6 +382,11 @@ Device (SPI1) { // Serial IO SPI1 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INT33C1") Name (_CID, "INT33C1") Name (_UID, 1) @@ -413,6 +438,11 @@ Device (UAR0) { // Serial IO UART0 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INT33C4") Name (_CID, "INT33C4") Name (_UID, 1) @@ -464,6 +494,11 @@ Device (UAR1) { // Serial IO UART1 Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INT33C5") Name (_CID, "INT33C5") Name (_UID, 1) @@ -502,6 +537,11 @@ Device (SDIO) { // Serial IO SDIO Controller + + /* + * FIXME: Per ACPI spec, device object must contain either an + * _HID object or an _ADR object, but should not contain both. + */ Name (_HID, "INT33C6") Name (_CID, "PNP0D40") Name (_UID, 1)
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37815
to look at the new patch set (#2).
Change subject: src/*.asl: Add FIXME comments ......................................................................
src/*.asl: Add FIXME comments
A device object must contain either a _HID object or an _ADR object, but should not contain both.
Change-Id: I12acd54679c2c712d5f2a9dce5fb28f4c966eb2b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/northbridge/amd/agesa/family14/acpi/northbridge.asl M src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl M src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl M src/northbridge/amd/pi/00630F01/acpi/northbridge.asl M src/northbridge/amd/pi/00660F01/acpi/northbridge.asl M src/northbridge/amd/pi/00730F01/acpi/northbridge.asl M src/soc/amd/stoneyridge/acpi/northbridge.asl M src/soc/intel/broadwell/acpi/serialio.asl M src/southbridge/intel/lynxpoint/acpi/serialio.asl 12 files changed, 134 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37815/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37815 )
Change subject: src/*.asl: Add FIXME comments ......................................................................
Patch Set 2:
I'm a little confused by this change. Aren't the non-mainboard changes already on master from CB:36318? I don't see any benefit in having the not-for-merge be its parent. If you rebase on master, do most of the files' changes go away.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37815 )
Change subject: src/*.asl: Add FIXME comments ......................................................................
Patch Set 2:
Patch Set 2:
I'm a little confused by this change. Aren't the non-mainboard changes already on master from CB:36318? I don't see any benefit in having the not-for-merge be its parent. If you rebase on master, do most of the files' changes go away.
reverted here: https://review.coreboot.org/c/coreboot/+/37710
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37815 )
Change subject: src/*.asl: Add FIXME comments ......................................................................
Patch Set 2:
reverted here: https://review.coreboot.org/c/coreboot/+/37710
Thanks - I'm no longer confused!
Hello Kyösti Mälkki, Patrick Rudolph, Marshall Dawson, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37815
to look at the new patch set (#4).
Change subject: src/*.asl: Add FIXME comments ......................................................................
src/*.asl: Add FIXME comments
A device object must contain either a _HID object or an _ADR object, but should not contain both.
Change-Id: I12acd54679c2c712d5f2a9dce5fb28f4c966eb2b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/soc/intel/broadwell/acpi/serialio.asl M src/southbridge/intel/lynxpoint/acpi/serialio.asl 5 files changed, 98 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37815/4
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37815 )
Change subject: src/*.asl: Add FIXME comments ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Marshall Dawson (Code Review)