Attention is currently required from: Tarun Tuli, Raymond Chung, Paul Menzel, Zhuohao Lee.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69964 )
Change subject: mb/google/brya/var/gaelin: Configure audio in devicetree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/gaelin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/69964/comment/b6a3b4e8_2afcf009
PS3, Line 239: device ref hda on
does it necessary to turn hda on? I think it's for sound wire device, ALC1015 uses i2s only?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69964
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8cacce6cb4b3e55fc7332bb9eb9ac20848fc5b
Gerrit-Change-Number: 69964
Gerrit-PatchSet: 3
Gerrit-Owner: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bruce Chiang
brucechiang@msi.corp-partner.google.com
Gerrit-CC: Eason Chang
easonchang@msi.corp-partner.google.com
Gerrit-CC: Eddy Lu
eddylu@ami.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 03:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment