[S] Change in coreboot[main]: mb/google/brya: Do not select HAVE_ACPI_RESUME

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro.

Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/86422?usp=email )

Change subject: mb/google/brya: Do not select HAVE_ACPI_RESUME
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86422/comment/7ba0e34d_05f6eba1?usp... :
PS1, Line 10: Also trigger a fail-safe board
            : reset if the system resumes from S3.
> Sorry for not being clear in my comment. How can Chromebook with ChromeOS go into ACPI S3 if it’s not advertised by firmware?

Paul, I agree with your concern. To me, the change in bootblock.c doesn't make sense. S3 is the firmware's published state, and if the firmware doesn't provide any hooks to allow the system to enter S3, why do we need an additional reset at resume path? It just seems like dead code to me. I haven't adopted it for MTL, if you noticed.