Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18457 )
Change subject: soc/intel/common: Add bootblock common stage file ......................................................................
Patch Set 33:
(2 comments)
https://review.coreboot.org/c/coreboot/+/18457/33/src/soc/intel/common/basec... File src/soc/intel/common/basecode/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/18457/33/src/soc/intel/common/basec... PS33, Line 70: bb_ops->bootblock_cpu_init(); Should we also check pointer prior calling functions? This may be flagged later by code analysis tools.
https://review.coreboot.org/c/coreboot/+/18457/33/src/soc/intel/common/basec... File src/soc/intel/common/basecode/include/intelbasecode/bootblock.h:
https://review.coreboot.org/c/coreboot/+/18457/33/src/soc/intel/common/basec... PS33, Line 20: void (*bootblock_soc_early_init)(void); : void (*bootblock_soc_init)(void); : void (*bootblock_pch_early_init)(void); : void (*bootblock_pch_init)(void); : void (*bootblock_cpu_early_init)(void); : void (*bootblock_cpu_init)(void); How about removing 'bootblock' prefix? I think is redundant. This will also follows the way interfaces are defined in file src/include/device/device.h
-
Bernardo Perez Priego (Code Review)