Change in coreboot[master]: mb/google/dedede: Set the GPIO to EDGE_BOTH trigger for SD card CD pin
Hello Kaiyen Chang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48303
to review the following change.
Change subject: mb/google/dedede: Set the GPIO to EDGE_BOTH trigger for SD card CD pin ......................................................................
mb/google/dedede: Set the GPIO to EDGE_BOTH trigger for SD card CD pin
The default setting of LEVEL/EDGE of GPIO is zero, which is LEVEL trigger. So we need to set the GPIO to EDGE_BOTH trigger for SD card CD pin in advance in coreboot to avoid the probabilistic interrupt storm occuring during the period that kernel is configuring the GPIO for SD card CD pin.
BUG=b:174336541 TEST=Run 1500 reboot iterations successfully
Signed-off-by: Kaiyen Chang kaiyen.chang@intel.corp-partner.google.com Change-Id: I4782c7efd9ab107e4894257b6e042f7477d90fac --- M src/mainboard/google/dedede/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/48303/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index 1d8d21d..39d35f5 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -381,7 +381,7 @@ PAD_NC(GPD10, NONE),
/* SD card detect virtual GPIO */ - PAD_CFG_GPI_GPIO_DRIVER(VGPIO_39, NONE, PLTRST), + PAD_CFG_GPI_GPIO_DRIVER_EDGE_BOTH(VGPIO_39, NONE, PLTRST),
};
Hello build bot (Jenkins), Kaiyen Chang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48303
to look at the new patch set (#2).
Change subject: mb/google/dedede: Set the GPIO to EDGE_BOTH trigger for SD card CD pin ......................................................................
mb/google/dedede: Set the GPIO to EDGE_BOTH trigger for SD card CD pin
The default setting of LEVEL/EDGE of GPIO is zero, which is LEVEL trigger. So we need to set the GPIO to EDGE_BOTH trigger for SD card CD pin in advance in coreboot to avoid the probabilistic interrupt storm occuring during the period that kernel is configuring the GPIO for SD card CD pin.
BUG=b:174336541 TEST=Run 1500 reboot iterations successfully
Signed-off-by: Kaiyen Chang kaiyen.chang@intel.corp-partner.google.com Change-Id: I4782c7efd9ab107e4894257b6e042f7477d90fac --- M src/mainboard/google/dedede/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/48303/2
Kaiyen Chang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48303 )
Change subject: soc/intel/common/gpio_defs: Add PAD_TRIG(OFF) in PAD_CFG_GPI_GPIO_DRIVER ......................................................................
Abandoned
-
Kaiyen Chang (Code Review)