Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62893 )
Change subject: mb/google/corsola: Revise power-on sequence of PS8640 ......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62893/comment/6ba7a675_428d9ebb PS5, Line 10: waveform of power-on sequence How do you measure it?
measured with oscilloscope
https://review.coreboot.org/c/coreboot/+/62893/comment/8395d12f_c54c833f PS5, Line 9: The power-on sequence of PS8640 needs to be modified because the : waveform of power-on sequence do not meet the spec of PS8640. Is there a user noticeable display issue?
https://review.coreboot.org/c/coreboot/+/62893/comment/bb6bb56a_56263cbd PS5, Line 10: do does
https://review.coreboot.org/c/coreboot/+/62893/comment/9e3b9e29_f4d98fd1 PS5, Line 16: TEST=show fw display normally in krabby. Please document, that/if boot time is now 110 ms longer. Are Chromium OS’ boottime requirements still met?
https://review.coreboot.org/c/coreboot/+/62893/comment/5ae29d1b_1adfd304 PS5, Line 17: result of waveform meets the spec. As the datasheet is not publicly accessible, what does it look like?
-
Paul Menzel (Code Review)