Sindhoor Tilak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42278 )
Change subject: post_code: add defines for missing postcode values ......................................................................
Patch Set 6:
(8 comments)
https://review.coreboot.org/c/coreboot/+/42278/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42278/3//COMMIT_MSG@7 PS3, Line 7: postcode: addition and reorganization of postcodes
Ack
Done
https://review.coreboot.org/c/coreboot/+/42278/3//COMMIT_MSG@11 PS3, Line 11: - added postcodes mainly target intel/amd for now
I'm sorry just want to confirm, did you mean the reorganization of existing ones and new additions n […]
Done
https://review.coreboot.org/c/coreboot/+/42278/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42278/4//COMMIT_MSG@7 PS4, Line 7: postcode: added and reorganized postcodes
Imperative mood: […]
Done
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co... File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co... PS4, Line 296: POST_FSP_MULTI_PHASE_SI_INIT_ENTRY
that's missing and the cause why jenkins complains
Done
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co... PS4, Line 75: POST_BOOTBLOCK_PRE_C_EXIT
why _EXIT? […]
Done
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co... PS4, Line 141: POST_ENTRY_BOOTBLOCK_STACK
at this point already 48 postcodes are used.
Done
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co... PS4, Line 198: initialization
if that refers to mainboard_after_memory_init() I'd call it […]
Done
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co... PS4, Line 214: reset of
I don't understand the meaning of this sentence
I've updated the description.
-
Sindhoor Tilak (Code Review)