Change in coreboot[master]: soc/mediatek: add new driver 'msdc' for eMMC - coreboot-gerrit

1 Apr 2021


      Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Wenbin Mei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51966 )
Change subject: soc/mediatek: add new driver 'msdc' for eMMC
......................................................................
Patch Set 5:
(3 comments)
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/51966/comment/e71b31ea_db4bb7c9 
PS4, Line 61:
...
space
Ack
https://review.coreboot.org/c/coreboot/+/51966/comment/6cb45b45_b2ce0e96 
PS4, Line 133: MSDC_PAD_TUNE_CMD_SEL
...
Move to the previous line
Done
https://review.coreboot.org/c/coreboot/+/51966/comment/e8f335a8_2fbf3a62 
PS4, Line 459: "%s
...
Align with BIOS_ERR
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
Gerrit-Change-Number: 51966
Gerrit-PatchSet: 5
Gerrit-Owner: Wenbin Mei wenbin.mei@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 11:01:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment