Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29872 )
Change subject: mb/poppy/variant/nami: Move FPMCU_INT_L gpios to B group ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29872/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/gpio.c:
https://review.coreboot.org/#/c/29872/2/src/mainboard/google/poppy/variants/... PS2, Line 413: PAD_CFG_GPI_APIC
Yes, I tried PAD_CFG_GPI_APIC_INVERT and I don't see the spi device and I don't see interrupts in /p […]
If you have SOC_INTEL_COMMON_BLOCK_GPIO_ITSS_POL_CFG selected in your repo for skylake, then I would expect PAD_CFG_GPI_APIC_INVERT to work as expected. One thing to check would be to assert the line manually and see what the pad input is and if you see any interrupts.
-
Furquan Shaikh (Code Review)