Nico Huber has posted comments on this change. ( https://review.coreboot.org/29449 )
Change subject: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/29449/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29449/1//COMMIT_MSG@7 PS1, Line 7: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector The original Git rule is 55 chars for the summary. We allow more but it's unnecessary here (e.g. `x86/acpi: ...` would still carry the same information).
https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c@1282 PS1, Line 1282: printk(BIOS_ERR, "No RSDP found, wake up from S3 not " Please don't break the string literal. If you want to honor the line limit, break after the comma. (But you don't have to, there's an unwritten exception for string literals.)
https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c@1282 PS1, Line 1282: BIOS_ERR rather BIOS_ALERT