Hello Joel Kitching, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32748
to review the following change.
Change subject: 3rdparty: Uprev vboot submodule to upstream master ......................................................................
3rdparty: Uprev vboot submodule to upstream master
This patch uprevs the vboot submodule to the new upstream HEAD commit
dac763c782 Make vboot -Wtype-limits compliant
Change-Id: I363e218e019b25483bc4c06315ca4e0e34599daf Signed-off-by: Julius Werner jwerner@chromium.org --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/32748/1
diff --git a/3rdparty/vboot b/3rdparty/vboot index e7edff6..dac763c 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit e7edff6653e16ed915c3ad12234d133d1ef4dcc9 +Subproject commit dac763c782ce05476dec02e855f349d2b6f3a910
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32748 )
Change subject: 3rdparty: Uprev vboot submodule to upstream master ......................................................................
Patch Set 1: Code-Review+1
Looks fine, but you might consider using the util script to generate this CL, so that its format is consistent with other uprev commits.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32748 )
Change subject: 3rdparty: Uprev vboot submodule to upstream master ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32748 )
Change subject: 3rdparty: Uprev vboot submodule to upstream master ......................................................................
3rdparty: Uprev vboot submodule to upstream master
This patch uprevs the vboot submodule to the new upstream HEAD commit
dac763c782 Make vboot -Wtype-limits compliant
Change-Id: I363e218e019b25483bc4c06315ca4e0e34599daf Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32748 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Joel Kitching kitching@google.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Joel Kitching: Looks good to me, but someone else must approve
diff --git a/3rdparty/vboot b/3rdparty/vboot index e7edff6..dac763c 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit e7edff6653e16ed915c3ad12234d133d1ef4dcc9 +Subproject commit dac763c782ce05476dec02e855f349d2b6f3a910