Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40556 )
Change subject: src/soc/intel/xeon_sp/cpx: Fixups for dual-socket
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/40556/1/src/soc/intel/xeon_sp/cpx/c...
File src/soc/intel/xeon_sp/cpx/cpu.c:
https://review.coreboot.org/c/coreboot/+/40556/1/src/soc/intel/xeon_sp/cpx/c...
PS1, Line 31: BIOS_INFO
It might be better to keep this debug message? but set level to SPEW?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40556
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50a181b89f40777a9f7b3881280c7bacf1b947cb
Gerrit-Change-Number: 40556
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Apr 2020 15:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment