Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48925 )
Change subject: device/pnp,util/sconfig: introduce and use `REG8` resource type
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48925/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48925/3//COMMIT_MSG@12
PS3, Line 12: 0x[3f]
Why these? I would have expected `0x[^7]` or maybe `0x[^78]`.
no, 0x[^7] includes 0x60-0x6f (io), 0x3* (misc / enable register). io is used for 0x6*, irq for 0x70-73, drq for 0x74-0x75; reg8 is meant to be used for miscellaneous registers like 0x30, 0xf0-0xfe
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36679148cbfdbd1e38b3c4ce092562769f9806ab
Gerrit-Change-Number: 48925
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 27 Dec 2020 17:30:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment