Change in ...coreboot[master]: nb/intel/sandybridge: Remove variable set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32926

Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................

nb/intel/sandybridge: Remove variable set but not used

Change-Id: Iaac05f73d2ba892d3ec7ee2ac0c16a98f2fce5bc
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/sandybridge/early_dmi.c
1 file changed, 64 insertions(+), 65 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/32926/1

diff --git a/src/northbridge/intel/sandybridge/early_dmi.c b/src/northbridge/intel/sandybridge/early_dmi.c
index db49040..6d41a2d 100644
--- a/src/northbridge/intel/sandybridge/early_dmi.c
+++ b/src/northbridge/intel/sandybridge/early_dmi.c
@@ -19,7 +19,6 @@

void early_init_dmi(void)
 {
-	volatile u32 tmp;
    int i;

DMIBAR32(0x0914) |= 0x80000000;
@@ -39,133 +38,133 @@
    DMIBAR32(0x090c) &= 0xfe1fffff;
    DMIBAR32(0x092c) &= 0xfe1fffff;

-	tmp = DMIBAR32(0x0904);	// !!! = 0x7a1842ec
+	DMIBAR32(0x0904);	// !!! = 0x7a1842ec
    DMIBAR32(0x0904) = 0x7a1842ec;
-	tmp = DMIBAR32(0x090c);	// !!! = 0x00000208
+	DMIBAR32(0x090c);	// !!! = 0x00000208
    DMIBAR32(0x090c) = 0x00000128;
-	tmp = DMIBAR32(0x0924);	// !!! = 0x7a1842ec
+	DMIBAR32(0x0924);	// !!! = 0x7a1842ec
    DMIBAR32(0x0924) = 0x7a1842ec;
-	tmp = DMIBAR32(0x092c);	// !!! = 0x00000208
+	DMIBAR32(0x092c);	// !!! = 0x00000208
    DMIBAR32(0x092c) = 0x00000128;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x46139008
+	DMIBAR32(0x0700);	// !!! = 0x46139008
    DMIBAR32(0x0700) = 0x46139008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x46139008
+	DMIBAR32(0x0720);	// !!! = 0x46139008
    DMIBAR32(0x0720) = 0x46139008;
-	tmp = DMIBAR32(0x0c04);	// !!! = 0x2e680008
+	DMIBAR32(0x0c04);	// !!! = 0x2e680008
    DMIBAR32(0x0c04) = 0x2e680008;
-	tmp = DMIBAR32(0x0904);	// !!! = 0x7a1842ec
+	DMIBAR32(0x0904);	// !!! = 0x7a1842ec
    DMIBAR32(0x0904) = 0x3a1842ec;
-	tmp = DMIBAR32(0x0924);	// !!! = 0x7a1842ec
+	DMIBAR32(0x0924);	// !!! = 0x7a1842ec
    DMIBAR32(0x0924) = 0x3a1842ec;
-	tmp = DMIBAR32(0x0910);	// !!! = 0x00006300
+	DMIBAR32(0x0910);	// !!! = 0x00006300
    DMIBAR32(0x0910) = 0x00004300;
-	tmp = DMIBAR32(0x0930);	// !!! = 0x00006300
+	DMIBAR32(0x0930);	// !!! = 0x00006300
    DMIBAR32(0x0930) = 0x00004300;
-	tmp = DMIBAR32(0x0a00);	// !!! = 0x03042010
+	DMIBAR32(0x0a00);	// !!! = 0x03042010
    DMIBAR32(0x0a00) = 0x03042018;
-	tmp = DMIBAR32(0x0a10);	// !!! = 0x03042010
+	DMIBAR32(0x0a10);	// !!! = 0x03042010
    DMIBAR32(0x0a10) = 0x03042018;
-	tmp = DMIBAR32(0x0a20);	// !!! = 0x03042010
+	DMIBAR32(0x0a20);	// !!! = 0x03042010
    DMIBAR32(0x0a20) = 0x03042018;
-	tmp = DMIBAR32(0x0a30);	// !!! = 0x03042010
+	DMIBAR32(0x0a30);	// !!! = 0x03042010
    DMIBAR32(0x0a30) = 0x03042018;
-	tmp = DMIBAR32(0x0c00);	// !!! = 0x29700c08
+	DMIBAR32(0x0c00);	// !!! = 0x29700c08
    DMIBAR32(0x0c00) = 0x29700c08;
-	tmp = DMIBAR32(0x0a04);	// !!! = 0x0c0708f0
+	DMIBAR32(0x0a04);	// !!! = 0x0c0708f0
    DMIBAR32(0x0a04) = 0x0c0718f0;
-	tmp = DMIBAR32(0x0a14);	// !!! = 0x0c0708f0
+	DMIBAR32(0x0a14);	// !!! = 0x0c0708f0
    DMIBAR32(0x0a14) = 0x0c0718f0;
-	tmp = DMIBAR32(0x0a24);	// !!! = 0x0c0708f0
+	DMIBAR32(0x0a24);	// !!! = 0x0c0708f0
    DMIBAR32(0x0a24) = 0x0c0718f0;
-	tmp = DMIBAR32(0x0a34);	// !!! = 0x0c0708f0
+	DMIBAR32(0x0a34);	// !!! = 0x0c0708f0
    DMIBAR32(0x0a34) = 0x0c0718f0;
-	tmp = DMIBAR32(0x0900);	// !!! = 0x50000000
+	DMIBAR32(0x0900);	// !!! = 0x50000000
    DMIBAR32(0x0900) = 0x50000000;
-	tmp = DMIBAR32(0x0920);	// !!! = 0x50000000
+	DMIBAR32(0x0920);	// !!! = 0x50000000
    DMIBAR32(0x0920) = 0x50000000;
-	tmp = DMIBAR32(0x0908);	// !!! = 0x51ffffff
+	DMIBAR32(0x0908);	// !!! = 0x51ffffff
    DMIBAR32(0x0908) = 0x51ffffff;
-	tmp = DMIBAR32(0x0928);	// !!! = 0x51ffffff
+	DMIBAR32(0x0928);	// !!! = 0x51ffffff
    DMIBAR32(0x0928) = 0x51ffffff;
-	tmp = DMIBAR32(0x0a00);	// !!! = 0x03042018
+	DMIBAR32(0x0a00);	// !!! = 0x03042018
    DMIBAR32(0x0a00) = 0x03042018;
-	tmp = DMIBAR32(0x0a10);	// !!! = 0x03042018
+	DMIBAR32(0x0a10);	// !!! = 0x03042018
    DMIBAR32(0x0a10) = 0x03042018;
-	tmp = DMIBAR32(0x0a20);	// !!! = 0x03042018
+	DMIBAR32(0x0a20);	// !!! = 0x03042018
    DMIBAR32(0x0a20) = 0x03042018;
-	tmp = DMIBAR32(0x0a30);	// !!! = 0x03042018
+	DMIBAR32(0x0a30);	// !!! = 0x03042018
    DMIBAR32(0x0a30) = 0x03042018;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x46139008
+	DMIBAR32(0x0700);	// !!! = 0x46139008
    DMIBAR32(0x0700) = 0x46139008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x46139008
+	DMIBAR32(0x0720);	// !!! = 0x46139008
    DMIBAR32(0x0720) = 0x46139008;
-	tmp = DMIBAR32(0x0904);	// !!! = 0x3a1842ec
+	DMIBAR32(0x0904);	// !!! = 0x3a1842ec
    DMIBAR32(0x0904) = 0x3a1846ec;
-	tmp = DMIBAR32(0x0924);	// !!! = 0x3a1842ec
+	DMIBAR32(0x0924);	// !!! = 0x3a1842ec
    DMIBAR32(0x0924) = 0x3a1846ec;
-	tmp = DMIBAR32(0x0a00);	// !!! = 0x03042018
+	DMIBAR32(0x0a00);	// !!! = 0x03042018
    DMIBAR32(0x0a00) = 0x03042018;
-	tmp = DMIBAR32(0x0a10);	// !!! = 0x03042018
+	DMIBAR32(0x0a10);	// !!! = 0x03042018
    DMIBAR32(0x0a10) = 0x03042018;
-	tmp = DMIBAR32(0x0a20);	// !!! = 0x03042018
+	DMIBAR32(0x0a20);	// !!! = 0x03042018
    DMIBAR32(0x0a20) = 0x03042018;
-	tmp = DMIBAR32(0x0a30);	// !!! = 0x03042018
+	DMIBAR32(0x0a30);	// !!! = 0x03042018
    DMIBAR32(0x0a30) = 0x03042018;
-	tmp = DMIBAR32(0x0908);	// !!! = 0x51ffffff
+	DMIBAR32(0x0908);	// !!! = 0x51ffffff
    DMIBAR32(0x0908) = 0x51ffffff;
-	tmp = DMIBAR32(0x0928);	// !!! = 0x51ffffff
+	DMIBAR32(0x0928);	// !!! = 0x51ffffff
    DMIBAR32(0x0928) = 0x51ffffff;
-	tmp = DMIBAR32(0x0c00);	// !!! = 0x29700c08
+	DMIBAR32(0x0c00);	// !!! = 0x29700c08
    DMIBAR32(0x0c00) = 0x29700c08;
-	tmp = DMIBAR32(0x0c0c);	// !!! = 0x16063400
+	DMIBAR32(0x0c0c);	// !!! = 0x16063400
    DMIBAR32(0x0c0c) = 0x00063400;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x46139008
+	DMIBAR32(0x0700);	// !!! = 0x46139008
    DMIBAR32(0x0700) = 0x46339008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x46139008
+	DMIBAR32(0x0720);	// !!! = 0x46139008
    DMIBAR32(0x0720) = 0x46339008;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x46339008
+	DMIBAR32(0x0700);	// !!! = 0x46339008
    DMIBAR32(0x0700) = 0x45339008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x46339008
+	DMIBAR32(0x0720);	// !!! = 0x46339008
    DMIBAR32(0x0720) = 0x45339008;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x45339008
+	DMIBAR32(0x0700);	// !!! = 0x45339008
    DMIBAR32(0x0700) = 0x453b9008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x45339008
+	DMIBAR32(0x0720);	// !!! = 0x45339008
    DMIBAR32(0x0720) = 0x453b9008;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x453b9008
+	DMIBAR32(0x0700);	// !!! = 0x453b9008
    DMIBAR32(0x0700) = 0x45bb9008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x453b9008
+	DMIBAR32(0x0720);	// !!! = 0x453b9008
    DMIBAR32(0x0720) = 0x45bb9008;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x45bb9008
+	DMIBAR32(0x0700);	// !!! = 0x45bb9008
    DMIBAR32(0x0700) = 0x45fb9008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x45bb9008
+	DMIBAR32(0x0720);	// !!! = 0x45bb9008
    DMIBAR32(0x0720) = 0x45fb9008;
-	tmp = DMIBAR32(0x0914);	// !!! = 0x9021a080
+	DMIBAR32(0x0914);	// !!! = 0x9021a080
    DMIBAR32(0x0914) = 0x9021a280;
-	tmp = DMIBAR32(0x0934);	// !!! = 0x9021a080
+	DMIBAR32(0x0934);	// !!! = 0x9021a080
    DMIBAR32(0x0934) = 0x9021a280;
-	tmp = DMIBAR32(0x0914);	// !!! = 0x9021a280
+	DMIBAR32(0x0914);	// !!! = 0x9021a280
    DMIBAR32(0x0914) = 0x9821a280;
-	tmp = DMIBAR32(0x0934);	// !!! = 0x9021a280
+	DMIBAR32(0x0934);	// !!! = 0x9021a280
    DMIBAR32(0x0934) = 0x9821a280;
-	tmp = DMIBAR32(0x0a00);	// !!! = 0x03042018
+	DMIBAR32(0x0a00);	// !!! = 0x03042018
    DMIBAR32(0x0a00) = 0x03242018;
-	tmp = DMIBAR32(0x0a10);	// !!! = 0x03042018
+	DMIBAR32(0x0a10);	// !!! = 0x03042018
    DMIBAR32(0x0a10) = 0x03242018;
-	tmp = DMIBAR32(0x0a20);	// !!! = 0x03042018
+	DMIBAR32(0x0a20);	// !!! = 0x03042018
    DMIBAR32(0x0a20) = 0x03242018;
-	tmp = DMIBAR32(0x0a30);	// !!! = 0x03042018
+	DMIBAR32(0x0a30);	// !!! = 0x03042018
    DMIBAR32(0x0a30) = 0x03242018;
-	tmp = DMIBAR32(0x0258);	// !!! = 0x40000600
+	DMIBAR32(0x0258);	// !!! = 0x40000600
    DMIBAR32(0x0258) = 0x60000600;
-	tmp = DMIBAR32(0x0904);	// !!! = 0x3a1846ec
+	DMIBAR32(0x0904);	// !!! = 0x3a1846ec
    DMIBAR32(0x0904) = 0x2a1846ec;
-	tmp = DMIBAR32(0x0914);	// !!! = 0x9821a280
+	DMIBAR32(0x0914);	// !!! = 0x9821a280
    DMIBAR32(0x0914) = 0x98200280;
-	tmp = DMIBAR32(0x0924);	// !!! = 0x3a1846ec
+	DMIBAR32(0x0924);	// !!! = 0x3a1846ec
    DMIBAR32(0x0924) = 0x2a1846ec;
-	tmp = DMIBAR32(0x0934);	// !!! = 0x9821a280
+	DMIBAR32(0x0934);	// !!! = 0x9821a280
    DMIBAR32(0x0934) = 0x98200280;
-	tmp = DMIBAR32(0x022c);	// !!! = 0x00c26460
+	DMIBAR32(0x022c);	// !!! = 0x00c26460
    DMIBAR32(0x022c) = 0x00c2403c;

early_pch_init_native_dmi_pre();

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32926 )

Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................

Patch Set 2:

Does it change the generated assembly?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32926 )

Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................

Patch Set 2:

"volatile" prevents the compiler from optimizing out the "unused" read value. It seems to be intended here. Also see CB:32948 CB:32939 CB:32938

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32926 )

Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................

Patch Set 2: Code-Review-1

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32926 )

Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................

Patch Set 2: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32926 )

Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................

Patch Set 2: -Code-Review
> Patch Set 2:
>
> "volatile" prevents the compiler from optimizing out the "unused" read value. It seems to be intended here. Also see CB:32948 CB:32939 CB:32938

Looks like "volatile" is on the DMIBAR macros already, this shouldn't be an issue.

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32926 )

Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................

Patch Set 4: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32926 )

Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................

nb/intel/sandybridge: Remove variable set but not used

Change-Id: Iaac05f73d2ba892d3ec7ee2ac0c16a98f2fce5bc
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32926
Reviewed-by: Patrick Georgi 
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/northbridge/intel/sandybridge/early_dmi.c
1 file changed, 64 insertions(+), 65 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Kyösti Mälkki: Looks good to me, but someone else must approve

diff --git a/src/northbridge/intel/sandybridge/early_dmi.c b/src/northbridge/intel/sandybridge/early_dmi.c
index db49040..6d41a2d 100644
--- a/src/northbridge/intel/sandybridge/early_dmi.c
+++ b/src/northbridge/intel/sandybridge/early_dmi.c
@@ -19,7 +19,6 @@

void early_init_dmi(void)
 {
-	volatile u32 tmp;
    int i;

DMIBAR32(0x0914) |= 0x80000000;
@@ -39,133 +38,133 @@
    DMIBAR32(0x090c) &= 0xfe1fffff;
    DMIBAR32(0x092c) &= 0xfe1fffff;

-	tmp = DMIBAR32(0x0904);	// !!! = 0x7a1842ec
+	DMIBAR32(0x0904);	// !!! = 0x7a1842ec
    DMIBAR32(0x0904) = 0x7a1842ec;
-	tmp = DMIBAR32(0x090c);	// !!! = 0x00000208
+	DMIBAR32(0x090c);	// !!! = 0x00000208
    DMIBAR32(0x090c) = 0x00000128;
-	tmp = DMIBAR32(0x0924);	// !!! = 0x7a1842ec
+	DMIBAR32(0x0924);	// !!! = 0x7a1842ec
    DMIBAR32(0x0924) = 0x7a1842ec;
-	tmp = DMIBAR32(0x092c);	// !!! = 0x00000208
+	DMIBAR32(0x092c);	// !!! = 0x00000208
    DMIBAR32(0x092c) = 0x00000128;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x46139008
+	DMIBAR32(0x0700);	// !!! = 0x46139008
    DMIBAR32(0x0700) = 0x46139008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x46139008
+	DMIBAR32(0x0720);	// !!! = 0x46139008
    DMIBAR32(0x0720) = 0x46139008;
-	tmp = DMIBAR32(0x0c04);	// !!! = 0x2e680008
+	DMIBAR32(0x0c04);	// !!! = 0x2e680008
    DMIBAR32(0x0c04) = 0x2e680008;
-	tmp = DMIBAR32(0x0904);	// !!! = 0x7a1842ec
+	DMIBAR32(0x0904);	// !!! = 0x7a1842ec
    DMIBAR32(0x0904) = 0x3a1842ec;
-	tmp = DMIBAR32(0x0924);	// !!! = 0x7a1842ec
+	DMIBAR32(0x0924);	// !!! = 0x7a1842ec
    DMIBAR32(0x0924) = 0x3a1842ec;
-	tmp = DMIBAR32(0x0910);	// !!! = 0x00006300
+	DMIBAR32(0x0910);	// !!! = 0x00006300
    DMIBAR32(0x0910) = 0x00004300;
-	tmp = DMIBAR32(0x0930);	// !!! = 0x00006300
+	DMIBAR32(0x0930);	// !!! = 0x00006300
    DMIBAR32(0x0930) = 0x00004300;
-	tmp = DMIBAR32(0x0a00);	// !!! = 0x03042010
+	DMIBAR32(0x0a00);	// !!! = 0x03042010
    DMIBAR32(0x0a00) = 0x03042018;
-	tmp = DMIBAR32(0x0a10);	// !!! = 0x03042010
+	DMIBAR32(0x0a10);	// !!! = 0x03042010
    DMIBAR32(0x0a10) = 0x03042018;
-	tmp = DMIBAR32(0x0a20);	// !!! = 0x03042010
+	DMIBAR32(0x0a20);	// !!! = 0x03042010
    DMIBAR32(0x0a20) = 0x03042018;
-	tmp = DMIBAR32(0x0a30);	// !!! = 0x03042010
+	DMIBAR32(0x0a30);	// !!! = 0x03042010
    DMIBAR32(0x0a30) = 0x03042018;
-	tmp = DMIBAR32(0x0c00);	// !!! = 0x29700c08
+	DMIBAR32(0x0c00);	// !!! = 0x29700c08
    DMIBAR32(0x0c00) = 0x29700c08;
-	tmp = DMIBAR32(0x0a04);	// !!! = 0x0c0708f0
+	DMIBAR32(0x0a04);	// !!! = 0x0c0708f0
    DMIBAR32(0x0a04) = 0x0c0718f0;
-	tmp = DMIBAR32(0x0a14);	// !!! = 0x0c0708f0
+	DMIBAR32(0x0a14);	// !!! = 0x0c0708f0
    DMIBAR32(0x0a14) = 0x0c0718f0;
-	tmp = DMIBAR32(0x0a24);	// !!! = 0x0c0708f0
+	DMIBAR32(0x0a24);	// !!! = 0x0c0708f0
    DMIBAR32(0x0a24) = 0x0c0718f0;
-	tmp = DMIBAR32(0x0a34);	// !!! = 0x0c0708f0
+	DMIBAR32(0x0a34);	// !!! = 0x0c0708f0
    DMIBAR32(0x0a34) = 0x0c0718f0;
-	tmp = DMIBAR32(0x0900);	// !!! = 0x50000000
+	DMIBAR32(0x0900);	// !!! = 0x50000000
    DMIBAR32(0x0900) = 0x50000000;
-	tmp = DMIBAR32(0x0920);	// !!! = 0x50000000
+	DMIBAR32(0x0920);	// !!! = 0x50000000
    DMIBAR32(0x0920) = 0x50000000;
-	tmp = DMIBAR32(0x0908);	// !!! = 0x51ffffff
+	DMIBAR32(0x0908);	// !!! = 0x51ffffff
    DMIBAR32(0x0908) = 0x51ffffff;
-	tmp = DMIBAR32(0x0928);	// !!! = 0x51ffffff
+	DMIBAR32(0x0928);	// !!! = 0x51ffffff
    DMIBAR32(0x0928) = 0x51ffffff;
-	tmp = DMIBAR32(0x0a00);	// !!! = 0x03042018
+	DMIBAR32(0x0a00);	// !!! = 0x03042018
    DMIBAR32(0x0a00) = 0x03042018;
-	tmp = DMIBAR32(0x0a10);	// !!! = 0x03042018
+	DMIBAR32(0x0a10);	// !!! = 0x03042018
    DMIBAR32(0x0a10) = 0x03042018;
-	tmp = DMIBAR32(0x0a20);	// !!! = 0x03042018
+	DMIBAR32(0x0a20);	// !!! = 0x03042018
    DMIBAR32(0x0a20) = 0x03042018;
-	tmp = DMIBAR32(0x0a30);	// !!! = 0x03042018
+	DMIBAR32(0x0a30);	// !!! = 0x03042018
    DMIBAR32(0x0a30) = 0x03042018;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x46139008
+	DMIBAR32(0x0700);	// !!! = 0x46139008
    DMIBAR32(0x0700) = 0x46139008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x46139008
+	DMIBAR32(0x0720);	// !!! = 0x46139008
    DMIBAR32(0x0720) = 0x46139008;
-	tmp = DMIBAR32(0x0904);	// !!! = 0x3a1842ec
+	DMIBAR32(0x0904);	// !!! = 0x3a1842ec
    DMIBAR32(0x0904) = 0x3a1846ec;
-	tmp = DMIBAR32(0x0924);	// !!! = 0x3a1842ec
+	DMIBAR32(0x0924);	// !!! = 0x3a1842ec
    DMIBAR32(0x0924) = 0x3a1846ec;
-	tmp = DMIBAR32(0x0a00);	// !!! = 0x03042018
+	DMIBAR32(0x0a00);	// !!! = 0x03042018
    DMIBAR32(0x0a00) = 0x03042018;
-	tmp = DMIBAR32(0x0a10);	// !!! = 0x03042018
+	DMIBAR32(0x0a10);	// !!! = 0x03042018
    DMIBAR32(0x0a10) = 0x03042018;
-	tmp = DMIBAR32(0x0a20);	// !!! = 0x03042018
+	DMIBAR32(0x0a20);	// !!! = 0x03042018
    DMIBAR32(0x0a20) = 0x03042018;
-	tmp = DMIBAR32(0x0a30);	// !!! = 0x03042018
+	DMIBAR32(0x0a30);	// !!! = 0x03042018
    DMIBAR32(0x0a30) = 0x03042018;
-	tmp = DMIBAR32(0x0908);	// !!! = 0x51ffffff
+	DMIBAR32(0x0908);	// !!! = 0x51ffffff
    DMIBAR32(0x0908) = 0x51ffffff;
-	tmp = DMIBAR32(0x0928);	// !!! = 0x51ffffff
+	DMIBAR32(0x0928);	// !!! = 0x51ffffff
    DMIBAR32(0x0928) = 0x51ffffff;
-	tmp = DMIBAR32(0x0c00);	// !!! = 0x29700c08
+	DMIBAR32(0x0c00);	// !!! = 0x29700c08
    DMIBAR32(0x0c00) = 0x29700c08;
-	tmp = DMIBAR32(0x0c0c);	// !!! = 0x16063400
+	DMIBAR32(0x0c0c);	// !!! = 0x16063400
    DMIBAR32(0x0c0c) = 0x00063400;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x46139008
+	DMIBAR32(0x0700);	// !!! = 0x46139008
    DMIBAR32(0x0700) = 0x46339008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x46139008
+	DMIBAR32(0x0720);	// !!! = 0x46139008
    DMIBAR32(0x0720) = 0x46339008;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x46339008
+	DMIBAR32(0x0700);	// !!! = 0x46339008
    DMIBAR32(0x0700) = 0x45339008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x46339008
+	DMIBAR32(0x0720);	// !!! = 0x46339008
    DMIBAR32(0x0720) = 0x45339008;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x45339008
+	DMIBAR32(0x0700);	// !!! = 0x45339008
    DMIBAR32(0x0700) = 0x453b9008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x45339008
+	DMIBAR32(0x0720);	// !!! = 0x45339008
    DMIBAR32(0x0720) = 0x453b9008;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x453b9008
+	DMIBAR32(0x0700);	// !!! = 0x453b9008
    DMIBAR32(0x0700) = 0x45bb9008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x453b9008
+	DMIBAR32(0x0720);	// !!! = 0x453b9008
    DMIBAR32(0x0720) = 0x45bb9008;
-	tmp = DMIBAR32(0x0700);	// !!! = 0x45bb9008
+	DMIBAR32(0x0700);	// !!! = 0x45bb9008
    DMIBAR32(0x0700) = 0x45fb9008;
-	tmp = DMIBAR32(0x0720);	// !!! = 0x45bb9008
+	DMIBAR32(0x0720);	// !!! = 0x45bb9008
    DMIBAR32(0x0720) = 0x45fb9008;
-	tmp = DMIBAR32(0x0914);	// !!! = 0x9021a080
+	DMIBAR32(0x0914);	// !!! = 0x9021a080
    DMIBAR32(0x0914) = 0x9021a280;
-	tmp = DMIBAR32(0x0934);	// !!! = 0x9021a080
+	DMIBAR32(0x0934);	// !!! = 0x9021a080
    DMIBAR32(0x0934) = 0x9021a280;
-	tmp = DMIBAR32(0x0914);	// !!! = 0x9021a280
+	DMIBAR32(0x0914);	// !!! = 0x9021a280
    DMIBAR32(0x0914) = 0x9821a280;
-	tmp = DMIBAR32(0x0934);	// !!! = 0x9021a280
+	DMIBAR32(0x0934);	// !!! = 0x9021a280
    DMIBAR32(0x0934) = 0x9821a280;
-	tmp = DMIBAR32(0x0a00);	// !!! = 0x03042018
+	DMIBAR32(0x0a00);	// !!! = 0x03042018
    DMIBAR32(0x0a00) = 0x03242018;
-	tmp = DMIBAR32(0x0a10);	// !!! = 0x03042018
+	DMIBAR32(0x0a10);	// !!! = 0x03042018
    DMIBAR32(0x0a10) = 0x03242018;
-	tmp = DMIBAR32(0x0a20);	// !!! = 0x03042018
+	DMIBAR32(0x0a20);	// !!! = 0x03042018
    DMIBAR32(0x0a20) = 0x03242018;
-	tmp = DMIBAR32(0x0a30);	// !!! = 0x03042018
+	DMIBAR32(0x0a30);	// !!! = 0x03042018
    DMIBAR32(0x0a30) = 0x03242018;
-	tmp = DMIBAR32(0x0258);	// !!! = 0x40000600
+	DMIBAR32(0x0258);	// !!! = 0x40000600
    DMIBAR32(0x0258) = 0x60000600;
-	tmp = DMIBAR32(0x0904);	// !!! = 0x3a1846ec
+	DMIBAR32(0x0904);	// !!! = 0x3a1846ec
    DMIBAR32(0x0904) = 0x2a1846ec;
-	tmp = DMIBAR32(0x0914);	// !!! = 0x9821a280
+	DMIBAR32(0x0914);	// !!! = 0x9821a280
    DMIBAR32(0x0914) = 0x98200280;
-	tmp = DMIBAR32(0x0924);	// !!! = 0x3a1846ec
+	DMIBAR32(0x0924);	// !!! = 0x3a1846ec
    DMIBAR32(0x0924) = 0x2a1846ec;
-	tmp = DMIBAR32(0x0934);	// !!! = 0x9821a280
+	DMIBAR32(0x0934);	// !!! = 0x9821a280
    DMIBAR32(0x0934) = 0x98200280;
-	tmp = DMIBAR32(0x022c);	// !!! = 0x00c26460
+	DMIBAR32(0x022c);	// !!! = 0x00c26460
    DMIBAR32(0x022c) = 0x00c2403c;

early_pch_init_native_dmi_pre();