Attention is currently required from: Tarun Tuli, Subrata Banik, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69510 )
Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/69510/comment/66944d13_84902f40
PS4, Line 290: cpu_index
Do you rely on cpu_index being implicit 0 here because it is static? Would it make sense to initiali […]
Done
https://review.coreboot.org/c/coreboot/+/69510/comment/b7a94b2c_04e6d38f
PS4, Line 298: );
Looks like a too long line!?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c
Gerrit-Change-Number: 69510
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 09:27:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment