[S] Change in coreboot[master]: security/vboot: Update build rules using x86 SHA extension - coreboot-gerrit

3 Nov 2022


      Attention is currently required from: Raul Rangel, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68953 )
Change subject: security/vboot: Update build rules using x86 SHA extension
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68953/comment/df1d7ab5_f537ac1c 
PS3, Line 31:  
Just double-checking, are you sure this whitespace will be removed by make? We wouldn't want it to end up being `X86_SHA_EXT=" y"` (which coincidentally the current vboot Makefile would still count as a "yes", but just by accident).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f388e963eb82990cda41d3880e66ad937334908
Gerrit-Change-Number: 68953
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 01:15:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment