Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29662 )
Change subject: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/29662/5/src/soc/intel/braswell/bootblock/cac... File src/soc/intel/braswell/bootblock/cache_as_ram_cbootblock.S:
https://review.coreboot.org/#/c/29662/5/src/soc/intel/braswell/bootblock/cac... PS5, Line 21: #include <device/pci_def.h> that looks like a copy of drivers/intel/fsp1_1/cache_as_ram.inc. Why do you need to duplicate it ?
https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/romstage/car_... File src/soc/intel/braswell/romstage/car_stage.S:
https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/romstage/car_... PS2, Line 23:
I agree that might change filename into car_stage_entry.S, but don't understand your comment: […]
What I meant is 2. Replace all occurence of romstage_c_entry on braswell with car_stage_c_entry. In that case you don't need this file at all.
-
Patrick Rudolph (Code Review)