Change in ...coreboot[master]: ec/google/chromeec/ec_lpc: Remove unneeded 'else'

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

9 Jun 2019 9 Jun '19

1:12 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33333

Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ......................................................................

ec/google/chromeec/ec_lpc: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/33333/1

diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index 7293cff..f73bd1c 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -188,11 +188,10 @@ return EC_HOST_CMD_FLAG_VERSION_3; } else if (flags & EC_HOST_CMD_FLAG_LPC_ARGS_SUPPORTED) { return EC_HOST_CMD_FLAG_LPC_ARGS_SUPPORTED; - } else { - printk(BIOS_ERR, - "Chromium EC command version unsupported\n"); - return -1; } + printk(BIOS_ERR, + "Chromium EC command version unsupported\n"); + return -1; }

static int google_chromeec_command_v3(struct chromeec_command *cec_command)

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Vlado Cibic (Code Review)

9 Jun 9 Jun

2:32 p.m.

Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33333 )

Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/33333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Gerrit-Change-Number: 33333 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 09 Jun 2019 12:32:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

7 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33333 )

Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/33333/1/src/ec/google/chromeec/ec_lpc.c File src/ec/google/chromeec/ec_lpc.c:

https://review.coreboot.org/#/c/33333/1/src/ec/google/chromeec/ec_lpc.c@193 PS1, Line 193: "Chromium EC command version unsupported\n"); Does this fit in 80 lines now?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Gerrit-Change-Number: 33333 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 09 Jun 2019 17:00:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

7 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33333 )

Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33333/1/src/ec/google/chromeec/ec_lpc.c File src/ec/google/chromeec/ec_lpc.c:

https://review.coreboot.org/#/c/33333/1/src/ec/google/chromeec/ec_lpc.c@193 PS1, Line 193: "Chromium EC command version unsupported\n");

...

Does this fit in 80 lines now?

80 characters*

-- To view, visit https://review.coreboot.org/c/coreboot/+/33333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Gerrit-Change-Number: 33333 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 09 Jun 2019 17:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:23 p.m.

Hello Angel Pons, Vlado Cibic, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33333

to look at the new patch set (#2).

Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ......................................................................

ec/google/chromeec/ec_lpc: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 2 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/33333/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Gerrit-Change-Number: 33333 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

9:13 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33333 )

Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33333/1/src/ec/google/chromeec/ec_lpc.c File src/ec/google/chromeec/ec_lpc.c:

https://review.coreboot.org/#/c/33333/1/src/ec/google/chromeec/ec_lpc.c@193 PS1, Line 193: "Chromium EC command version unsupported\n");

...

80 characters*

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Gerrit-Change-Number: 33333 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 09 Jun 2019 19:13:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

9:43 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33333 )

Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Gerrit-Change-Number: 33333 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 09 Jun 2019 19:43:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

21 Jun 21 Jun

10:32 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33333 )

Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ......................................................................

ec/google/chromeec/ec_lpc: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33333 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 2 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index 7293cff..b7d183e 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -188,11 +188,9 @@ return EC_HOST_CMD_FLAG_VERSION_3; } else if (flags & EC_HOST_CMD_FLAG_LPC_ARGS_SUPPORTED) { return EC_HOST_CMD_FLAG_LPC_ARGS_SUPPORTED; - } else { - printk(BIOS_ERR, - "Chromium EC command version unsupported\n"); - return -1; } + printk(BIOS_ERR, "Chromium EC command version unsupported\n"); + return -1; }

static int google_chromeec_command_v3(struct chromeec_command *cec_command)

-- To view, visit https://review.coreboot.org/c/coreboot/+/33333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Gerrit-Change-Number: 33333 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1919

days inactive

1931

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Vlado Cibic (Code Review)