Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57345 )
Change subject: driver/intel/pmc_mux/conn: Add type-c info to coreboot table ......................................................................
Patch Set 6:
(1 comment)
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/73fc563e_1284f429 PS5, Line 115: mux = pmc->link_list->children;
I like the idea of removing mainboard dependency.
What do you think about the approach in patchset 6?
We can't write the info directly to the table from within .final() because .final() is called after each connector is registered, and we don't know how many registrations to wait for before we will have all the ports and can create our table entry.
If we wanted to get rid of the sysinfo_fill_type_c_info callback mechanism completely along with the two new globals added to this file, we could consider writing separate coreboot table entries, one for each connector instead of having just 1 coreboot table entry containing all connectors, but that would take up a little more space in the tables, and may require a bit more coding on the "read the tables" side to parse the entire table list to assure all connectors have been read from the list (I haven't yet reviewed the code on that side to make sure multiple entries of the same tag would not cause an issue, thought I'd get your opinion on it first).