Tim Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage
Override SMBIOS type 4 cpu voltage. For Delta Lake, 1.6V is expected.
Tested=Execute "dmidecode -t 4" to check if cpu voltage is correct.
Signed-off-by: Tim Chu Tim.Chu@quantatw.com Change-Id: I0ecbec8fb3dc79b8c3f3581d6193aade01bcd68e --- M src/mainboard/ocp/deltalake/ramstage.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/47562/1
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 9d57090..d48f85e 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -59,6 +59,12 @@ return slot_id_str; }
+/* Override SMBIOS type 4 cpu voltage */ +unsigned int smbios_cpu_get_voltage(void) +{ + return 0x90; /* This will return 1.6V which is expected value for Delta Lake */ +} + /* System Slot Socket, Stack, Type and Data bus width Information */ typedef struct { u8 stack;
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... PS1, Line 65: return 0x90; /* This will return 1.6V which is expected value for Delta Lake */ This function is supposed to return the processor voltage in 100mV units. 0x90 would translate to 14.4V?
Hello Philipp Deppenwiese, build bot (Jenkins), Jonathan Zhang, Ryback Hung, Christian Walter, Angel Pons, Bryant Ou, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47562
to look at the new patch set (#2).
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage
Override SMBIOS type 4 cpu voltage. For Delta Lake, 1.6V is expected.
Tested=Execute "dmidecode -t 4" to check if cpu voltage is correct.
Signed-off-by: Tim Chu Tim.Chu@quantatw.com Change-Id: I0ecbec8fb3dc79b8c3f3581d6193aade01bcd68e --- M src/mainboard/ocp/deltalake/ramstage.c 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/47562/2
Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... PS1, Line 65: return 0x90; /* This will return 1.6V which is expected value for Delta Lake */
This function is supposed to return the processor voltage in 100mV units. […]
In this field, BIT7 sets to 1 so that other bits represent cpu voltage times 10. 0x90h = 0x80h + (1.6 * 10) = 0x80h + 16 = 0x80h + 0x10h
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... PS1, Line 65: return 0x90; /* This will return 1.6V which is expected value for Delta Lake */
In this field, BIT7 sets to 1 so that other bits represent cpu voltage times 10. […]
Makes sense. should [CB:43904] be updated accordingly?
Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... PS1, Line 65: return 0x90; /* This will return 1.6V which is expected value for Delta Lake */
Makes sense. […]
CB:43904 has done the same thing in src/arch/x86/smbios.c line 698, but I think it is much more clear to return 0x90 here.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... PS1, Line 65: return 0x90; /* This will return 1.6V which is expected value for Delta Lake */
CB:43904 has done the same thing in src/arch/x86/smbios.c line 698, but I think it is much more clear to return 0x90 here.
Inconsistency would cause confusion. This patch and CB:43904 should match each other. Either option is fine, please make sure appropriate comment is added.
Hello Philipp Deppenwiese, build bot (Jenkins), Jonathan Zhang, Ryback Hung, Christian Walter, Angel Pons, Bryant Ou, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47562
to look at the new patch set (#3).
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage
Override SMBIOS type 4 cpu voltage. For Delta Lake, 1.6V is expected.
Tested=Execute "dmidecode -t 4" to check if cpu voltage is correct.
Signed-off-by: Tim Chu Tim.Chu@quantatw.com Change-Id: I0ecbec8fb3dc79b8c3f3581d6193aade01bcd68e --- M src/mainboard/ocp/deltalake/ramstage.c 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/47562/3
Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake... PS1, Line 65: return 0x90; /* This will return 1.6V which is expected value for Delta Lake */
CB:43904 has done the same thing in src/arch/x86/smbios. […]
Done. Remove 0x80h here.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage ......................................................................
mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage
Override SMBIOS type 4 cpu voltage. For Delta Lake, 1.6V is expected.
Tested=Execute "dmidecode -t 4" to check if cpu voltage is correct.
Signed-off-by: Tim Chu Tim.Chu@quantatw.com Change-Id: I0ecbec8fb3dc79b8c3f3581d6193aade01bcd68e Reviewed-on: https://review.coreboot.org/c/coreboot/+/47562 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jonathan Zhang jonzhang@fb.com --- M src/mainboard/ocp/deltalake/ramstage.c 1 file changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Jonathan Zhang: Looks good to me, approved
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 9d57090..52c55b8 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -59,6 +59,18 @@ return slot_id_str; }
+/* + * Override SMBIOS type 4 cpu voltage. + * BIT7 will set to 1 after value return. If BIT7 is set to 1, the remaining seven + * bits of this field are set to contain the processor's current voltage times 10. + */ +unsigned int smbios_cpu_get_voltage(void) +{ + /* This will return 1.6V which is expected value for Delta Lake + 10h = (1.6 * 10) = 16 */ + return 0x10; +} + /* System Slot Socket, Stack, Type and Data bus width Information */ typedef struct { u8 stack;
-
Jonathan Zhang (Code Review) -
Patrick Georgi (Code Review)
-
Tim Chu (Code Review)