Attention is currently required from: Angel Pons, Felix Singer, Patrick Rudolph.
Fabian Groffen has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/77046?usp=email )
Change subject: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H ......................................................................
Patch Set 8:
(5 comments)
Patchset:
PS8: more comments addressed
File src/mainboard/gigabyte/ga-h77m-d3h/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/77046/comment/312aebd4_eb96912b?usp... : PS7, Line 3: Scope (_SB) : { : Device (PWRB) : { : Name (_HID, EisaId ("PNP0C0C")) : } : } :
Does this also come from the B75 board? I remember checking the ACPI spec, and there's no reason to […]
Done
File src/mainboard/gigabyte/ga-h77m-d3h/acpi/pci.asl:
https://review.coreboot.org/c/coreboot/+/77046/comment/7ccf2f58_08a87585?usp... : PS7, Line 7: Name (_ADR, 0x001E0000)
Then I would simply remove this file
Done
File src/mainboard/gigabyte/ga-h77m-d3h/acpi/thermal.asl:
PS7:
I remember similar code caused ACPI errors for me on one of the H61 boards. […]
Done
File src/mainboard/gigabyte/ga-h77m-d3h/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/77046/comment/88b8a253_e06cb3a9?usp... : PS7, Line 10: gnvs->tpsv = PASSIVE_TEMPERATURE;
After removing `thermal. […]
Done