Change in coreboot[master]: soc/intel/alderlake: Enable FSP_USES_CB_DEBUG_EVENT_HANDLER Kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63009 )

Change subject: soc/intel/alderlake: Enable FSP_USES_CB_DEBUG_EVENT_HANDLER Kconfig
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS3:
> > Like to share one observation before we enable this feature on ADL.
> >
> > Currently we have fixed size cbmem console which is 8K in size and for sure not enough to hold the entire FSP-M debug log (after the CL gets landed). Typically, FSP-M debug log is very detailed and size is significantly high and I'm afraid we might not able to accommodate the same inside `cbmem -c`. I have verified that we are able to contain entire ramstage log inside `cbmem -c` with FSP debug enabled.
> >
> > config PRERAM_CBMEM_CONSOLE_SIZE
> >    hex
> >    default 0x2000
>
> If that overflows coreboot will simply stop filling that log. Debugging most issues in romstage require a hardware console anyway (memory not working) so I think that this is fine for early stages. It's like that for most platforms already. If you have enough CAR you could however try to increase it if you really want that log in memory.

Sure, that make sense as well.