Change in ...coreboot[master]: mb/google/hatch: Support 16MiB fmap

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Philip Chen (Code Review)

5 Apr 2019 5 Apr '19

10:43 p.m.

Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32219

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

mb/google/hatch: Support 16MiB fmap

Add an config and a fmd file for 16MiB fmap, so that we can support both 16MiB / 32MiB SPI flashroms.

BUG=b:129464811 TEST=build hatch firmware image with 16MiB fmap and verify fmap is updated by 'fuility dump_fmap'

Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Signed-off-by: Philip Chen philipchen@google.com --- M src/mainboard/google/hatch/Kconfig A src/mainboard/google/hatch/chromeos-16MiB.fmd 2 files changed, 52 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/32219/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 041ac2d..dd400b9 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -24,6 +24,11 @@

if BOARD_GOOGLE_BASEBOARD_HATCH

+config HATCH_HAS_16MB_FLASH + bool "Build for a board with a 16MiB SPI flash" + default n if BOARD_GOOGLE_HATCH_WHL || BOARD_GOOGLE_HATCH + default y + config CHROMEOS bool default y @@ -54,6 +59,11 @@ config UART_FOR_CONSOLE default 0

+config FMDFILE + string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-16MiB.fmd" if HATCH_HAS_16MB_FLASH + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" + config GBB_HWID string depends on CHROMEOS diff --git a/src/mainboard/google/hatch/chromeos-16MiB.fmd b/src/mainboard/google/hatch/chromeos-16MiB.fmd new file mode 100644 index 0000000..1594ab3 --- /dev/null +++ b/src/mainboard/google/hatch/chromeos-16MiB.fmd @@ -0,0 +1,42 @@ +FLASH@0xff000000 0x1000000 { + SI_ALL@0x0 0x400000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x3ff000 + } + SI_BIOS@0x400000 0xc00000 { + RW_SECTION_A@0x0 0x380000 { + VBLOCK_A@0x0 0x10000 + FW_MAIN_A(CBFS)@0x10000 0x36ffc0 + RW_FWID_A@0x37ffc0 0x40 + } + RW_SECTION_B@0x380000 0x380000 { + VBLOCK_B@0x0 0x10000 + FW_MAIN_B(CBFS)@0x10000 0x36ffc0 + RW_FWID_B@0x37ffc0 0x40 + } + RW_MISC@0x700000 0x30000 { + UNIFIED_MRC_CACHE@0x0 0x20000 { + RECOVERY_MRC_CACHE@0x0 0x10000 + RW_MRC_CACHE@0x10000 0x10000 + } + RW_ELOG(PRESERVE)@0x20000 0x4000 + RW_SHARED@0x24000 0x4000 { + SHARED_DATA@0x0 0x2000 + VBLOCK_DEV@0x2000 0x2000 + } + RW_VPD(PRESERVE)@0x28000 0x2000 + RW_NVRAM(PRESERVE)@0x2a000 0x6000 + } + RW_LEGACY(CBFS)@0x730000 0xd0000 + WP_RO@0x800000 0x400000 { + RO_VPD(PRESERVE)@0x0 0x4000 + RO_SECTION@0x4000 0x3fc000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0xef000 + COREBOOT(CBFS)@0xf0000 0x30c000 + } + } + } +}

Attachments:

attachment.htm (text/html — 6.9 KB)

Show replies by date

Paul Menzel (Code Review)

8 Apr 8 Apr

11:33 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/32219/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32219/1//COMMIT_MSG@9 PS1, Line 9: a an

https://review.coreboot.org/#/c/32219/1//COMMIT_MSG@9 PS1, Line 9: an a

https://review.coreboot.org/#/c/32219/1//COMMIT_MSG@10 PS1, Line 10: flashroms flash ROM chips.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 11:33:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Philip Chen (Code Review)

5:45 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32219

to look at the new patch set (#2).

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

mb/google/hatch: Support 16MiB fmap

Add a config and a fmd file for 16MiB fmap, so that we can support both 16MiB / 32MiB SPI flash ROM chips.

BUG=b:129464811 TEST=build hatch firmware image with 16MiB fmap and verify fmap is updated by 'fuility dump_fmap'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/32219/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Philip Chen (Code Review)

5:46 p.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/32219/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32219/1//COMMIT_MSG@9 PS1, Line 9: a

...

an

not "a"?

https://review.coreboot.org/#/c/32219/1//COMMIT_MSG@9 PS1, Line 9: an

...

a

Done

https://review.coreboot.org/#/c/32219/1//COMMIT_MSG@10 PS1, Line 10: flashroms

...

flash ROM chips.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 17:46:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:53 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32219/2/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32219/2/src/mainboard/google/hatch/Kconfig@4 PS2, Line 4: select BOARD_ROMSIZE_KB_32768 This config will have to be updated as well. Looking at this again, we can do something like this:

In Kconfig.name each board can set either BOARD_ROMSIZE_KB_32768 or BOARD_ROMSIZE_KB_16384 and FMDFILE can do the same selection as you have right now but based on BOARD_ROMSIZE_KB_* directly. Then, we can avoid having the HATCH_HAS_16MB_FLASH altogether.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 17:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Philip Chen (Code Review)

6:11 p.m.

Hello Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32219

to look at the new patch set (#3).

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

mb/google/hatch: Support 16MiB fmap

Add a config and a fmd file for 16MiB fmap, so that we can support both 16MiB / 32MiB SPI flash ROM chips.

BUG=b:129464811 TEST=build hatch firmware image with 16MiB fmap and verify fmap is updated by 'fuility dump_fmap'

Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Signed-off-by: Philip Chen philipchen@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name A src/mainboard/google/hatch/chromeos-16MiB.fmd 3 files changed, 50 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/32219/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Philip Chen (Code Review)

6:12 p.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32219/2/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32219/2/src/mainboard/google/hatch/Kconfig@4 PS2, Line 4: select BOARD_ROMSIZE_KB_32768

...

This config will have to be updated as well. Looking at this again, we can do something like this: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 18:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:11 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

Patch Set 3: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/32219/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32219/3//COMMIT_MSG@9 PS3, Line 9: Add a config and This is no longer true.

https://review.coreboot.org/#/c/32219/3/src/mainboard/google/hatch/Kconfig.n... File src/mainboard/google/hatch/Kconfig.name:

https://review.coreboot.org/#/c/32219/3/src/mainboard/google/hatch/Kconfig.n... PS3, Line 7: BOARD_ROMSIZE_KB_32768 nit: Can we put this and the other additions of BOARD_ROMSIZE_* here in alphabetical order?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 20:11:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Philip Chen (Code Review)

8:34 p.m.

Hello Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32219

to look at the new patch set (#4).

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

mb/google/hatch: Support 16MiB fmap

Add a fmd file for 16MiB fmap, so that we can support both 16MiB / 32MiB SPI flash ROM chips.

BUG=b:129464811 TEST=build hatch firmware image with 16MiB fmap and verify fmap is updated by 'fuility dump_fmap'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/32219/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Philip Chen (Code Review)

8:39 p.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32219/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32219/3//COMMIT_MSG@9 PS3, Line 9: Add a config and

...

This is no longer true.

Done

https://review.coreboot.org/#/c/32219/3/src/mainboard/google/hatch/Kconfig.n... File src/mainboard/google/hatch/Kconfig.name:

https://review.coreboot.org/#/c/32219/3/src/mainboard/google/hatch/Kconfig.n... PS3, Line 7: BOARD_ROMSIZE_KB_32768

...

nit: Can we put this and the other additions of BOARD_ROMSIZE_* here in alphabetical order?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 20:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:43 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 20:43:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9 Apr 9 Apr

5:23 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32219 )

Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................

mb/google/hatch: Support 16MiB fmap

Add a fmd file for 16MiB fmap, so that we can support both 16MiB / 32MiB SPI flash ROM chips.

BUG=b:129464811 TEST=build hatch firmware image with 16MiB fmap and verify fmap is updated by 'fuility dump_fmap'

Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Signed-off-by: Philip Chen philipchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32219 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name A src/mainboard/google/hatch/chromeos-16MiB.fmd 3 files changed, 50 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 041ac2d..63339f2 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -1,7 +1,6 @@

config BOARD_GOOGLE_BASEBOARD_HATCH def_bool n - select BOARD_ROMSIZE_KB_32768 select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_GENERIC @@ -54,6 +53,11 @@ config UART_FOR_CONSOLE default 0

+config FMDFILE + string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-16MiB.fmd" if BOARD_ROMSIZE_KB_16384 + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if BOARD_ROMSIZE_KB_32768 + config GBB_HWID string depends on CHROMEOS diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index edfa8e7..eb8e612 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -3,14 +3,17 @@ config BOARD_GOOGLE_HATCH bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_ROMSIZE_KB_32768 select SOC_INTEL_COMETLAKE

config BOARD_GOOGLE_HATCH_WHL bool "-> Hatch_whl" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_ROMSIZE_KB_32768 select SOC_INTEL_WHISKEYLAKE

config BOARD_GOOGLE_KOHAKU bool "-> Kohaku" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_ROMSIZE_KB_16384 select SOC_INTEL_COMETLAKE diff --git a/src/mainboard/google/hatch/chromeos-16MiB.fmd b/src/mainboard/google/hatch/chromeos-16MiB.fmd new file mode 100644 index 0000000..1594ab3 --- /dev/null +++ b/src/mainboard/google/hatch/chromeos-16MiB.fmd @@ -0,0 +1,42 @@ +FLASH@0xff000000 0x1000000 { + SI_ALL@0x0 0x400000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x3ff000 + } + SI_BIOS@0x400000 0xc00000 { + RW_SECTION_A@0x0 0x380000 { + VBLOCK_A@0x0 0x10000 + FW_MAIN_A(CBFS)@0x10000 0x36ffc0 + RW_FWID_A@0x37ffc0 0x40 + } + RW_SECTION_B@0x380000 0x380000 { + VBLOCK_B@0x0 0x10000 + FW_MAIN_B(CBFS)@0x10000 0x36ffc0 + RW_FWID_B@0x37ffc0 0x40 + } + RW_MISC@0x700000 0x30000 { + UNIFIED_MRC_CACHE@0x0 0x20000 { + RECOVERY_MRC_CACHE@0x0 0x10000 + RW_MRC_CACHE@0x10000 0x10000 + } + RW_ELOG(PRESERVE)@0x20000 0x4000 + RW_SHARED@0x24000 0x4000 { + SHARED_DATA@0x0 0x2000 + VBLOCK_DEV@0x2000 0x2000 + } + RW_VPD(PRESERVE)@0x28000 0x2000 + RW_NVRAM(PRESERVE)@0x2a000 0x6000 + } + RW_LEGACY(CBFS)@0x730000 0xd0000 + WP_RO@0x800000 0x400000 { + RO_VPD(PRESERVE)@0x0 0x4000 + RO_SECTION@0x4000 0x3fc000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0xef000 + COREBOOT(CBFS)@0xf0000 0x30c000 + } + } + } +}

-- To view, visit https://review.coreboot.org/c/coreboot/+/32219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826 Gerrit-Change-Number: 32219 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1908

days inactive

1912

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Philip Chen (Code Review)