Attention is currently required from: Alexander Couzens, Martin L Roth.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76962?usp=email )
Change subject: SNB+MRC boards: Do not redo PEI data struct in hook
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
And rolled all 13 or so boards into this patch.
File src/mainboard/lenovo/x220/early_init.c:
https://review.coreboot.org/c/coreboot/+/76962/comment/ed704d7f_3144c17d :
PS1, Line 12: uint8_t spdaddr[] = {0xa0, 0x00, 0xa2, 0x00};
: uint16_t usbcfg[16][3] = {
Mark these as const?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76962?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie349a8f400eecca3cdbc196ea0790aebe0549e39
Gerrit-Change-Number: 76962
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 14 Aug 2023 22:28:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment