Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19978 )
Change subject: rx6110sa: Add possibility to use both I2C and SMBus for the RTC ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/19978/1/src/drivers/i2c/rx6110sa/rx6110sa.c File src/drivers/i2c/rx6110sa/rx6110sa.c:
PS1, Line 30: rx611sa_write Why did you not use function name rx6110sa_write and rx6110sa_read?
PS1, Line 32: if (!CONFIG_RX6110SA_USE_SMBUS) : i2c_writeb(I2C_BUS_NUM, I2C_DEV_NUM, reg, val); : else : smbus_write_byte(dev, reg, val); You can leave the negation of CONFIG_RX6110SA_USE_SMBUS if you replace the lines. The same applies for rx611sa_read(...) function.