Attention is currently required from: Christian Walter, Erik van den Bogaert, Felix Held, Frans Hendriks, Fred Reitberger, Jan Samek, Jason Glenesk, Jon Murphy, Julius Werner, Matt DeVillier, Nick Vaccaro, Raul Rangel, Subrata Banik, Tim Van Patten.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78183?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: treewide: convert to %#x hex prints
......................................................................
Patch Set 4:
(3 comments)
File src/drivers/i2c/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/78183/comment/eeb0956e_75fa6ffd :
PS4, Line 65: %zx
Does `%#zx` work?
File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/78183/comment/82fe73de_0ff0dd6d :
PS4, Line 532: 0x%08x
See https://review.coreboot.org/c/coreboot/+/78183/1/src/drivers/i2c/tpm/cr50. […]
We may explicitly mention that in the commit message.
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/78183/comment/c225cf0e_d09a7757 :
PS4, Line 388: (
nit: Space before `(`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78183?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0d1ac4b920530635fb758c5165a6a99c11b414c8
Gerrit-Change-Number: 78183
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 28 Sep 2023 04:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Gerrit-MessageType: comment