Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Karthik Ramasubramanian.
Mark Hasemeyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74111 )
Change subject: mb/google/myst: Enable AP <-> GSC communication
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74111/comment/8421841e_78704ef6
PS5, Line 182: PAD_INT(GPIO_18, PULL_NONE, EDGE_LOW, STATUS_DELIVERY),
Doh! Missed this one too: GPIO_84
Also wondering if it makes sense to redefine everything that was defined here:
https://review.coreboot.org/c/coreboot/+/74095/4/src/mainboard/google/myst/v...
It seems like pins and bus numbers get redefined in numerous places. It would be nice to cut down on that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e235356b252a7b68a42da128ffd3189a829f117
Gerrit-Change-Number: 74111
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment