Attention is currently required from: Patrick Rudolph, Paul Menzel.
Maximilian Brune has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86385?usp=email )
Change subject: device/pci_rom: Keep track of VBIOS
......................................................................
Patch Set 4:
(1 comment)
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/86385/comment/9976907a_78640fd2?usp... :
PS4, Line 271: const char *scope = acpi_device_path(device);
: if (!scope) {
: printk(BIOS_ERR, "%s: Missing ACPI scope\n", dev_path(device));
: return;
: }
:
can we move this below the if condition? Makes it a bit more readable in my opinion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86385?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib27d30e3b07740d6098d4f7a5c4f5d8bce976f00
Gerrit-Change-Number: 86385
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 25 Feb 2025 12:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No