Change in ...coreboot[master]: mb/google/hatch: Pull up GPP_C13

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Philip Chen (Code Review)

12 Apr 2019 12 Apr '19

5:43 a.m.

Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32292

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

mb/google/hatch: Pull up GPP_C13

BUG=b:129306003 TEST=None

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/32292/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 0391dfe..ce9953f 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -147,7 +147,7 @@ * TODO Configure it back to invert mode, when * ITSS IPCx configuration is fixed in FSP. */ - PAD_CFG_GPI_APIC(GPP_C13, NONE, DEEP, LEVEL, NONE), + PAD_CFG_GPI_APIC(GPP_C13, 20K_PU, DEEP, LEVEL, NONE), /* C14 : BT_DISABLE_L */ PAD_CFG_GPO(GPP_C14, 1, DEEP), /* C15 : WWAN_DPR_SAR_ODL @@ -429,7 +429,7 @@ PAD_CFG_GPO(GPP_A18, 0, DEEP), /* EN_PP3300_WWAN */ };

-const struct pad_config * __weak +const struct pad_config *__weak variant_sleep_gpio_table(u8 slp_typ, size_t *num) { if (slp_typ == ACPI_S5) {

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Philip Chen (Code Review)

12 Apr 12 Apr

5:48 a.m.

Philip Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

mb/google/hatch: Pull up GPP_C13

BUG=b:129306003 TEST=None

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/32292/2

Philip Chen (Code Review)

5:52 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32292

to look at the new patch set (#3).

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

mb/google/hatch: Pull up GPP_C13

On EC end, we want to change this pin from push-pull to open-drain. And since there is no external pull-up resistor on the board, we'll have to configure this pin as internal-pull-up on AP end.

BUG=b:129306003 TEST=None

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/32292/3

Shelley Chen (Code Review)

6:42 a.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32292/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32292/3/src/mainboard/google/hatch/variants/... PS3, Line 150: 20K_PU UP_20K ?

Philip Chen (Code Review)

6:45 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32292

to look at the new patch set (#4).

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

mb/google/hatch: Pull up GPP_C13

On EC end, we want to change this pin from push-pull to open-drain. And since there is no external pull-up resistor on the board, we'll have to configure this pin as internal-pull-up on AP end.

BUG=b:129306003 TEST=None

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/32292/4

Philip Chen (Code Review)

6:48 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32292/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32292/3/src/mainboard/google/hatch/variants/... PS3, Line 150: 20K_PU

...

UP_20K ?

yeah, I just found the error and fixed it

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Shelley Chen shchen@google.com Gerrit-Comment-Date: Fri, 12 Apr 2019 06:48:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen shchen@google.com Gerrit-MessageType: comment

Philip Chen (Code Review)

19 Apr 19 Apr

2:48 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

Patch Set 4:

Ping, can we merge this change?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 19 Apr 2019 02:48:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:49 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 19 Apr 2019 02:49:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

3:05 a.m.

Furquan Shaikh has removed a vote on this change.

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

Removed Code-Review+2 by Furquan Shaikh furquan@google.com

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: deleteVote

Furquan Shaikh (Code Review)

3:06 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32292/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32292/4/src/mainboard/google/hatch/variants/... PS4, Line 150: UP_20K Actually can you add the pull-up to override table in hatch and hatch_whl. I don't think any of the other variants will need this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 19 Apr 2019 03:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Philip Chen (Code Review)

4:36 a.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32292

to look at the new patch set (#5).

Change subject: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl ......................................................................

mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

On EC end, we want to change this pin from push-pull to open-drain. And since there is no external pull-up resistor on the board, we'll have to configure this pin as internal-pull-up on AP end.

BUG=b:129306003 TEST=None

Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Signed-off-by: Philip Chen philipchen@google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c A src/mainboard/google/hatch/variants/hatch/gpio.c A src/mainboard/google/hatch/variants/hatch_whl/gpio.c 3 files changed, 65 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/32292/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

4:40 a.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl ......................................................................

Patch Set 5:

gpio.c files need to be added to Makefile.inc in respective folders.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 19 Apr 2019 04:40:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Philip Chen (Code Review)

7:08 a.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32292

to look at the new patch set (#6).

Change subject: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl ......................................................................

mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

On EC end, we want to change this pin from push-pull to open-drain. And since there is no external pull-up resistor on the board, we'll have to configure this pin as internal-pull-up on AP end.

BUG=b:129306003 TEST=None

Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Signed-off-by: Philip Chen philipchen@google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/hatch/Makefile.inc A src/mainboard/google/hatch/variants/hatch/gpio.c M src/mainboard/google/hatch/variants/hatch_whl/Makefile.inc A src/mainboard/google/hatch/variants/hatch_whl/gpio.c 5 files changed, 69 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/32292/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 6 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Philip Chen (Code Review)

7:10 a.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl ......................................................................

Patch Set 6:

(1 comment)

...

Patch Set 5:

gpio.c files need to be added to Makefile.inc in respective folders.

Ah, yes, thanks for pointing this out.

https://review.coreboot.org/#/c/32292/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32292/4/src/mainboard/google/hatch/variants/... PS4, Line 150: UP_20K

...

Actually can you add the pull-up to override table in hatch and hatch_whl. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 6 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 19 Apr 2019 07:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Philip Chen (Code Review)

25 Apr 25 Apr

2 p.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl ......................................................................

Patch Set 6:

Any more comments?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 6 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 25 Apr 2019 14:00:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:42 p.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 6 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 25 Apr 2019 14:42:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3:48 p.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32292 )

Change subject: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl ......................................................................

mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl

On EC end, we want to change this pin from push-pull to open-drain. And since there is no external pull-up resistor on the board, we'll have to configure this pin as internal-pull-up on AP end.

BUG=b:129306003 TEST=None

Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Signed-off-by: Philip Chen philipchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32292 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/hatch/Makefile.inc A src/mainboard/google/hatch/variants/hatch/gpio.c M src/mainboard/google/hatch/variants/hatch_whl/Makefile.inc A src/mainboard/google/hatch/variants/hatch_whl/gpio.c 5 files changed, 69 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 7e82b9b..df1c65e 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -428,7 +428,7 @@ PAD_CFG_GPO(GPP_A18, 0, DEEP), /* EN_PP3300_WWAN */ };

-const struct pad_config * __weak variant_sleep_gpio_table( +const struct pad_config *__weak variant_sleep_gpio_table( u8 slp_typ, size_t *num) { if (slp_typ == ACPI_S5) { diff --git a/src/mainboard/google/hatch/variants/hatch/Makefile.inc b/src/mainboard/google/hatch/variants/hatch/Makefile.inc index cf6ee5a..555cbb4 100644 --- a/src/mainboard/google/hatch/variants/hatch/Makefile.inc +++ b/src/mainboard/google/hatch/variants/hatch/Makefile.inc @@ -18,3 +18,5 @@ SPD_SOURCES += 8G_2666 # 0b011 SPD_SOURCES += 16G_2400 # 0b100 SPD_SOURCES += 16G_2666 # 0b101 + +ramstage-y += gpio.c diff --git a/src/mainboard/google/hatch/variants/hatch/gpio.c b/src/mainboard/google/hatch/variants/hatch/gpio.c new file mode 100644 index 0000000..7e73724 --- /dev/null +++ b/src/mainboard/google/hatch/variants/hatch/gpio.c @@ -0,0 +1,32 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2019 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +#include <arch/acpi.h> +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <commonlib/helpers.h> + +static const struct pad_config gpio_table[] = { + /* C13 : EC_PCH_INT_L + * TODO Configure it back to invert mode, when + * ITSS IPCx configuration is fixed in FSP. + */ + PAD_CFG_GPI_APIC(GPP_C13, UP_20K, PLTRST, LEVEL, NONE)}; + +const struct pad_config *override_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(gpio_table); + return gpio_table; +} diff --git a/src/mainboard/google/hatch/variants/hatch_whl/Makefile.inc b/src/mainboard/google/hatch/variants/hatch_whl/Makefile.inc index 4fa98ea..ecf5c2f 100644 --- a/src/mainboard/google/hatch/variants/hatch_whl/Makefile.inc +++ b/src/mainboard/google/hatch/variants/hatch_whl/Makefile.inc @@ -18,3 +18,5 @@ SPD_SOURCES += empty_ddr4 # 0b011 SPD_SOURCES += empty_ddr4 # 0b100 SPD_SOURCES += 8G_2666 # 0b101 + +ramstage-y += gpio.c diff --git a/src/mainboard/google/hatch/variants/hatch_whl/gpio.c b/src/mainboard/google/hatch/variants/hatch_whl/gpio.c new file mode 100644 index 0000000..7e73724 --- /dev/null +++ b/src/mainboard/google/hatch/variants/hatch_whl/gpio.c @@ -0,0 +1,32 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2019 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +#include <arch/acpi.h> +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <commonlib/helpers.h> + +static const struct pad_config gpio_table[] = { + /* C13 : EC_PCH_INT_L + * TODO Configure it back to invert mode, when + * ITSS IPCx configuration is fixed in FSP. + */ + PAD_CFG_GPI_APIC(GPP_C13, UP_20K, PLTRST, LEVEL, NONE)}; + +const struct pad_config *override_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(gpio_table); + return gpio_table; +}

-- To view, visit https://review.coreboot.org/c/coreboot/+/32292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756 Gerrit-Change-Number: 32292 Gerrit-PatchSet: 7 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1985

days inactive

1998

days old

coreboot-gerrit@coreboot.org

16 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Philip Chen (Code Review)
Shelley Chen (Code Review)