HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32121
Change subject: src: Remove 'assert' function name and open parenthesis ......................................................................
src: Remove 'assert' function name and open parenthesis
Change-Id: If3dbb1422915f2bfc8ff42c5d9eeeece9e4e9f80 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/spi/spi-generic.c M src/drivers/spi/tpm/tpm.c M src/mainboard/google/poppy/romstage.c M src/soc/cavium/common/bdk-coreboot.c M src/soc/intel/common/block/gpio/gpio.c M src/soc/nvidia/tegra210/cpu.c 6 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/32121/1
diff --git a/src/drivers/spi/spi-generic.c b/src/drivers/spi/spi-generic.c index 84a42d1..f2e4311 100644 --- a/src/drivers/spi/spi-generic.c +++ b/src/drivers/spi/spi-generic.c @@ -103,7 +103,7 @@ deduct_opcode_len = !!(ctrlr->flags & SPI_CNTRLR_DEDUCT_OPCODE_LEN); ctrlr_max = ctrlr->max_xfer_size;
- assert (ctrlr_max != 0); + assert(ctrlr_max != 0);
/* Assume opcode is always one byte and deduct it from the cmd_len as the hardware has a separate register for the opcode. */ diff --git a/src/drivers/spi/tpm/tpm.c b/src/drivers/spi/tpm/tpm.c index aad7610..740f7be 100644 --- a/src/drivers/spi/tpm/tpm.c +++ b/src/drivers/spi/tpm/tpm.c @@ -360,7 +360,7 @@ static void tpm2_write_access_reg(uint8_t cmd) { /* Writes to access register can set only 1 bit at a time. */ - assert (!(cmd & (cmd - 1))); + assert(!(cmd & (cmd - 1)));
tpm2_write_reg(TPM_ACCESS_REG, &cmd, sizeof(cmd)); } diff --git a/src/mainboard/google/poppy/romstage.c b/src/mainboard/google/poppy/romstage.c index 9de1602..197081e 100644 --- a/src/mainboard/google/poppy/romstage.c +++ b/src/mainboard/google/poppy/romstage.c @@ -81,7 +81,7 @@ char spd_name[SPD_PART_LEN+1] = { 0 }; const struct dram_info *info = &spd_info[type];
- assert (info->type_code == spd[SPD_DRAM_TYPE_OFF]); + assert(info->type_code == spd[SPD_DRAM_TYPE_OFF]);
/* Module type */ printk(BIOS_INFO, "SPD: module type is %s\n", info->str); diff --git a/src/soc/cavium/common/bdk-coreboot.c b/src/soc/cavium/common/bdk-coreboot.c index 066155e..9da1c7d 100644 --- a/src/soc/cavium/common/bdk-coreboot.c +++ b/src/soc/cavium/common/bdk-coreboot.c @@ -52,8 +52,8 @@ struct i2c_msg seg[2]; u32 buf;
- assert (num_bytes < 5); - assert (ia_width_bytes < 3); + assert(num_bytes < 5); + assert(ia_width_bytes < 3);
seg[0].flags = 0; seg[0].slave = dev_addr; @@ -94,8 +94,8 @@ struct i2c_msg seg; u8 buf[10];
- assert (num_bytes <= 8); - assert (ia_width_bytes < 3); + assert(num_bytes <= 8); + assert(ia_width_bytes < 3);
memcpy(buf, &internal_addr, ia_width_bytes); memcpy(&buf[ia_width_bytes], &data, num_bytes); diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c index 0065a6c..00afa44 100644 --- a/src/soc/intel/common/block/gpio/gpio.c +++ b/src/soc/intel/common/block/gpio/gpio.c @@ -513,7 +513,7 @@ int i;
routes = soc_pmc_gpio_routes(&num_routes); - assert (routes != NULL); + assert(routes != NULL); for (i = 0; i < num_routes; i++, routes++) { if (pmc_gpe_num == routes->pmc) return routes->gpio; diff --git a/src/soc/nvidia/tegra210/cpu.c b/src/soc/nvidia/tegra210/cpu.c index 8d74bd3..11b7082 100644 --- a/src/soc/nvidia/tegra210/cpu.c +++ b/src/soc/nvidia/tegra210/cpu.c @@ -34,7 +34,7 @@ CRC_RST_CPUG_CLR_CORE3 | CRC_RST_CPUG_CLR_CX3, };
- assert (cpu < CONFIG_MAX_CPUS); + assert(cpu < CONFIG_MAX_CPUS);
/* Clear reset of CPU components. */ write32(CLK_RST_REG(rst_cpug_cmplx_clr), cpu_clocks[cpu]);
Hello Patrick Rudolph, Julius Werner, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32121
to look at the new patch set (#2).
Change subject: src: Remove space between 'assert' function name and open parenthesis ......................................................................
src: Remove space between 'assert' function name and open parenthesis
Change-Id: If3dbb1422915f2bfc8ff42c5d9eeeece9e4e9f80 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/spi/spi-generic.c M src/drivers/spi/tpm/tpm.c M src/mainboard/google/poppy/romstage.c M src/soc/cavium/common/bdk-coreboot.c M src/soc/intel/common/block/gpio/gpio.c M src/soc/nvidia/tegra210/cpu.c 6 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/32121/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32121 )
Change subject: src: Remove space between 'assert' function name and open parenthesis ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)