Change in coreboot[master]: mb/google/dedede/var/madoo: Configure USB port setting for Madoo

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Dtrain Hsu (Code Review)

23 Jul 2020 23 Jul '20

8:56 a.m.

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43750 )

Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure USB port setting for Madoo

Follow schematic to modify USB port setting and clean up I2C clock tuning.

USB2 [0]: USB Type C Port 0 USB2 [1]: USB Type C Port 1 USB2 [2]: None USB2 [3]: USB Type A Port 1 USB2 [4]: None USB2 [5]: Camera USB2 [6]: None USB2 [7]: WLAN module - BlueTooth

USB3 [0]: USB Type C Port 0 (M/B side) USB3 [1]: USB Type C Port 1 (Sub/B side) USB3 [2]: None USB3 [3]: USB Type A Port 1 USB3 [4]: None USB3 [5]: None

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 26 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/43750/1

diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index d8ffd3d..926a289 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -1,7 +1,10 @@ chip soc/intel/jasperlake

# USB Port Configuration + register "usb2_ports[2]" = "USB2_PORT_EMPTY" # Not Used + register "usb2_ports[4]" = "USB2_PORT_EMPTY" # Not Used register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera + register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Not Used

# Intel Common SoC Config #+-------------------+---------------------------+ @@ -24,9 +27,6 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 66, - .fall_time_ns = 90, - .data_hold_time_ns = 350, }, .i2c[1] = { .speed = I2C_SPEED_FAST, @@ -42,7 +42,29 @@ }, }" device domain 0 on - device pci 14.0 on end + device pci 14.0 on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + device usb 2.2 off end + end + chip drivers/usb/acpi + register "desc" = ""Camera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + chip drivers/usb/acpi + register "desc" = ""Integrated Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" + device usb 2.7 on end + end + chip drivers/usb/acpi + device usb 3.2 off end + end + end + end + end # USB xHCI device pci 15.0 on end device pci 15.2 on end device pci 1c.7 on end

Attachments:

attachment.htm (text/html — 6.0 KB)

Show replies by date

Karthik Ramasubramanian (Code Review)

24 Jul 24 Jul

9:28 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43750 )

Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43750/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43750/1/src/mainboard/google/dedede... PS1, Line 56: chip drivers/usb/acpi : register "desc" = ""Integrated Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" : device usb 2.7 on end : end This is the same as baseboard configuration. So no need to override it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 Gerrit-Change-Number: 43750 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Jul 2020 07:28:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

10 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43750

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure USB port setting for Madoo

Follow schematic to modify USB port setting and clean up I2C clock tuning.

USB2 [0]: USB Type C Port 0 USB2 [1]: USB Type C Port 1 USB2 [2]: None USB2 [3]: USB Type A Port 1 USB2 [4]: None USB2 [5]: Camera USB2 [6]: None USB2 [7]: WLAN module - BlueTooth

USB3 [0]: USB Type C Port 0 (M/B side) USB3 [1]: USB Type C Port 1 (Sub/B side) USB3 [2]: None USB3 [3]: USB Type A Port 1 USB3 [4]: None USB3 [5]: None

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/43750/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 Gerrit-Change-Number: 43750 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-MessageType: newpatchset

Dtrain Hsu (Code Review)

10:01 a.m.

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43750 )

Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43750/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/overridetree.cb:

...

This is the same as baseboard configuration. So no need to override it.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 Gerrit-Change-Number: 43750 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Jul 2020 08:01:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

10:35 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43750

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure USB port setting for Madoo

Follow schematic to modify USB port setting and clean up I2C clock tuning.

USB2 [0]: USB Type C Port 0 USB2 [1]: USB Type C Port 1 USB2 [2]: None USB2 [3]: USB Type A Port 1 USB2 [4]: None USB2 [5]: Camera USB2 [6]: None USB2 [7]: WLAN module - BlueTooth

USB3 [0]: USB Type C Port 0 (M/B side) USB3 [1]: USB Type C Port 1 (Sub/B side) USB3 [2]: None USB3 [3]: USB Type A Port 1 USB3 [4]: None USB3 [5]: None

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/43750/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/43750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 Gerrit-Change-Number: 43750 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

11:17 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43750 )

Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 Gerrit-Change-Number: 43750 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Jul 2020 09:17:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

7:17 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43750 )

Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 Gerrit-Change-Number: 43750 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 17:17:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

28 Jul 28 Jul

9:19 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43750 )

Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure USB port setting for Madoo

Follow schematic to modify USB port setting and clean up I2C clock tuning.

USB2 [0]: USB Type C Port 0 USB2 [1]: USB Type C Port 1 USB2 [2]: None USB2 [3]: USB Type A Port 1 USB2 [4]: None USB2 [5]: Camera USB2 [6]: None USB2 [7]: WLAN module - BlueTooth

USB3 [0]: USB Type C Port 0 (M/B side) USB3 [1]: USB Type C Port 1 (Sub/B side) USB3 [2]: None USB3 [3]: USB Type A Port 1 USB3 [4]: None USB3 [5]: None

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43750 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 21 insertions(+), 8 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved EricR Lai: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index d8ffd3d..c793866 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -1,7 +1,10 @@ chip soc/intel/jasperlake

# Intel Common SoC Config #+-------------------+---------------------------+ @@ -14,7 +17,7 @@ #| I2C0 | Trackpad | #| I2C1 | Digitizer | #| I2C2 | Touchscreen | - #| I2C3 | Camera | + #| I2C3 | | #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ @@ -24,9 +27,6 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 66, - .fall_time_ns = 90, - .data_hold_time_ns = 350, }, .i2c[1] = { .speed = I2C_SPEED_FAST, @@ -34,15 +34,28 @@ .i2c[2] = { .speed = I2C_SPEED_FAST, }, - .i2c[3] = { - .speed = I2C_SPEED_FAST, - }, .i2c[4] = { .speed = I2C_SPEED_FAST, }, }" device domain 0 on - device pci 14.0 on end + device pci 14.0 on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + device usb 2.2 off end + end + chip drivers/usb/acpi + register "desc" = ""Camera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + chip drivers/usb/acpi + device usb 3.2 off end + end + end + end + end # USB xHCI device pci 15.0 on end device pci 15.2 on end device pci 1c.7 on end

-- To view, visit https://review.coreboot.org/c/coreboot/+/43750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia73593f52adee3806e725127891f084a08bf1360 Gerrit-Change-Number: 43750 Gerrit-PatchSet: 7 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1562

days inactive

1567

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Dtrain Hsu (Code Review)
EricR Lai (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)