HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34539 )
Change subject: ec/google/wilco: Hide wilco symbols when unused ......................................................................
ec/google/wilco: Hide wilco symbols when unused
This clean-up my .config from unused wilco symbols.
Change-Id: I813d3fe57b97e2c1ba67e1e3674de256c2529029 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/wilco/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/34539/1
diff --git a/src/ec/google/wilco/Kconfig b/src/ec/google/wilco/Kconfig index 4202c1d..25d7cfa 100644 --- a/src/ec/google/wilco/Kconfig +++ b/src/ec/google/wilco/Kconfig @@ -6,6 +6,8 @@ help Google Wilco Embedded Controller interface.
+if EC_GOOGLE_WILCO + config EC_BASE_ACPI_DATA hex default 0x930 @@ -46,3 +48,5 @@ mailbox interface data region. This data buffer is used along with the host command and data registers to drive the EC mailbox interface. This is also the MEC EMI base address. + +endif # EC_GOOGLE_WILCO
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34539 )
Change subject: ec/google/wilco: Hide wilco symbols when unused ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34539/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34539/2//COMMIT_MSG@9 PS2, Line 9: clean-up cleans up
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34539
to look at the new patch set (#3).
Change subject: ec/google/wilco: Hide wilco symbols when unused ......................................................................
ec/google/wilco: Hide wilco symbols when unused
This cleans up .config file from unused wilco symbols.
Change-Id: I813d3fe57b97e2c1ba67e1e3674de256c2529029 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/wilco/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/34539/3
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34539 )
Change subject: ec/google/wilco: Hide wilco symbols when unused ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34539 )
Change subject: ec/google/wilco: Hide wilco symbols when unused ......................................................................
Patch Set 3: Code-Review+2
thanks.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34539 )
Change subject: ec/google/wilco: Hide wilco symbols when unused ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34539/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34539/2//COMMIT_MSG@9 PS2, Line 9: clean-up
cleans up
Done
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34539 )
Change subject: ec/google/wilco: Hide wilco symbols when unused ......................................................................
ec/google/wilco: Hide wilco symbols when unused
This cleans up .config file from unused wilco symbols.
Change-Id: I813d3fe57b97e2c1ba67e1e3674de256c2529029 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34539 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/wilco/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/ec/google/wilco/Kconfig b/src/ec/google/wilco/Kconfig index 4202c1d..25d7cfa 100644 --- a/src/ec/google/wilco/Kconfig +++ b/src/ec/google/wilco/Kconfig @@ -6,6 +6,8 @@ help Google Wilco Embedded Controller interface.
+if EC_GOOGLE_WILCO + config EC_BASE_ACPI_DATA hex default 0x930 @@ -46,3 +48,5 @@ mailbox interface data region. This data buffer is used along with the host command and data registers to drive the EC mailbox interface. This is also the MEC EMI base address. + +endif # EC_GOOGLE_WILCO
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Martin Roth (Code Review)
-
Paul Menzel (Code Review)