Attention is currently required from: Henry Sun, Paul Menzel, Shou-Chieh Hsu, Karthik Ramasubramanian.
Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56988 )
Change subject: mb/google/dedede/var/corori: Generate RAM ID and SPD file
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56988/comment/c5a67684_20136a57
PS1, Line 13:
Maybe mention, that some generic file `lp4x-spd-1. […]
Done
File src/mainboard/google/dedede/variants/corori/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/56988/comment/be5a1364_731ed6cc
PS1, Line 11: # Part Name
Should this stay in the file?
Use gen_part_id.go tool to auto generate must be deleted.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia11b5db145deeea838a8f5949accdb11e13342f2
Gerrit-Change-Number: 56988
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 17 Aug 2021 08:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment