Change in coreboot[master]: ec/google/chromeec: Add powerinfo support - coreboot-gerrit

25 Nov 2021


      Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59189 )
Change subject: ec/google/chromeec: Add powerinfo support
......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/59189/comment/ce62e2ca_abcd7f04 
PS3, Line 1848: void
...
shouldn't `resp` be an argument so you can actually get the data back from the host command?
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59189
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75b109592b327df11d1101bcf32a364c2ae7feac
Gerrit-Change-Number: 59189
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Thu, 25 Nov 2021 12:12:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment