Attention is currently required from: Patrick Rudolph, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61315 )
Change subject: drivers/intel/usb4/retimer: Add acpi name method
......................................................................
Patch Set 5:
(1 comment)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/61315/comment/2f1184d7_c4035e4a
PS5, Line 354: acpigen_write_device
IDK, this one let Intel to deal with it :p Maybe the driver need this hard code?
If we're going to use this for the `acpi_name` callback, I think we should use it for the actual name as well. The name here shouldn't matter as far as the kernel is concerned. Either that, or change the print below to hardcode a string instead of %s/acpi_device_name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfa8b204894409b11936e5f221c218daa206cc02
Gerrit-Change-Number: 61315
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 26 Jan 2022 02:41:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment