Attention is currently required from: Fred Reitberger, Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Maximilian Brune.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86272?usp=email )
Change subject: soc/amd/cezanne/chipset.cb: Enable gpp_bridge_[a/b/c] by default
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/soc/amd/cezanne/chipset.cb:
https://review.coreboot.org/c/coreboot/+/86272/comment/8060ee02_1455f999?usp... :
PS2, Line 90: xgbe_0
is xgbe_0 and xgbe_1 always disabled by FSP?
the two xgbe controllers can't be used on the silicon this was originally tested with, so i'd guess that they just can't show up showed up in that case. if some out of tree board uses those, it needs to make sure to enable them. this patch is about the bridges though. if we end up adding upds for this, that's something for another patch
https://review.coreboot.org/c/coreboot/+/86272/comment/51aa5f73_7d634ca0?usp... :
PS2, Line 96: i2s_ac97
is i2s_ac97 always disabled by FSP?
uh, that's a good question to which i don't know the answer. i'd say that it'll probably be fine to have it disabled here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86272?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie34bb2abc0211963b2613d1b50b1767df31c1062
Gerrit-Change-Number: 86272
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 17:01:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com