Change in coreboot[master]: soc/amd/picasso: mark usb2_phy_tune struct as packed

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43780 )

Change subject: soc/amd/picasso: mark usb2_phy_tune struct as packed
......................................................................

soc/amd/picasso: mark usb2_phy_tune struct as packed

Since the binary layout of this struct matters, it should be marked as
packed. Since all struct elements are uint8_t, this shouldn't result in
a different layout though.

Change-Id: I6a390c3a3f35eaf8a72928b4cef0e9f405770619
Signed-off-by: Felix Held 
---
M src/soc/amd/picasso/chip.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/43780/1

diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h
index 1950691..3bcd3cc 100644
--- a/src/soc/amd/picasso/chip.h
+++ b/src/soc/amd/picasso/chip.h
@@ -16,7 +16,7 @@
 /*
   USB 2.0 PHY Parameters
 */
-struct usb2_phy_tune {
+struct __packed usb2_phy_tune {
    /* Disconnect Threshold Adjustment. Range 0 - 0x7 */
    uint8_t	com_pds_tune;
    /* Squelch Threshold Adjustment. Range 0 - 0x7 */

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43780 )

Change subject: soc/amd/picasso: mark usb2_phy_tune struct as packed
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43780 )

Change subject: soc/amd/picasso: mark usb2_phy_tune struct as packed
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Hello build bot (Jenkins), Angel Pons, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43780

to look at the new patch set (#2).

Change subject: soc/amd/picasso: mark usb2_phy_tune struct as packed
......................................................................

soc/amd/picasso: mark usb2_phy_tune struct as packed

Since the binary layout of this struct matters, it should be marked as
packed. Since all struct elements are uint8_t, this shouldn't result in
a different layout though.

BUG=b:161923068

Change-Id: I6a390c3a3f35eaf8a72928b4cef0e9f405770619
Signed-off-by: Felix Held 
---
M src/soc/amd/picasso/chip.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/43780/2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43780 )

Change subject: soc/amd/picasso: mark usb2_phy_tune struct as packed
......................................................................

soc/amd/picasso: mark usb2_phy_tune struct as packed

Since the binary layout of this struct matters, it should be marked as
packed. Since all struct elements are uint8_t, this shouldn't result in
a different layout though.

BUG=b:161923068

Change-Id: I6a390c3a3f35eaf8a72928b4cef0e9f405770619
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43780
Reviewed-by: Aaron Durbin 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/picasso/chip.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h
index 1950691..3bcd3cc 100644
--- a/src/soc/amd/picasso/chip.h
+++ b/src/soc/amd/picasso/chip.h
@@ -16,7 +16,7 @@
 /*
   USB 2.0 PHY Parameters
 */
-struct usb2_phy_tune {
+struct __packed usb2_phy_tune {
    /* Disconnect Threshold Adjustment. Range 0 - 0x7 */
    uint8_t	com_pds_tune;
    /* Squelch Threshold Adjustment. Range 0 - 0x7 */