Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Angel Pons. Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50913 )
Change subject: intel/common/block/cpu: Add APIs to get CPU info from lapic ID ......................................................................
Patch Set 3:
(4 comments)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/50913/comment/4bd3d1d0_ccce8269 PS2, Line 410: *
nit: space before *
done.
https://review.coreboot.org/c/coreboot/+/50913/comment/0a767e54_e69157f6 PS2, Line 411: cpuid_regs.eax
`cpuid_get_max_func()`
Done
https://review.coreboot.org/c/coreboot/+/50913/comment/8defa695_aafbe8b7 PS2, Line 413: /* Check for extended CPU topology CPUID support */ : if (cpuid_regs.eax >= CPUID_EXTENDED_CPU_TOPOLOGY) : cpu_id_op = CPUID_EXTENDED_CPU_TOPOLOGY; : if (cpuid_regs.eax >= CPUID_EXTENDED_CPU_TOPOLOGY_V2) : cpu_id_op = CPUID_EXTENDED_CPU_TOPOLOGY_V2;
suggestion: the two ifs next to each other could be misread, reversing the order allows you to use e […]
Done
https://review.coreboot.org/c/coreboot/+/50913/comment/c8cbc9f7_4cfde1db PS2, Line 422: level_num
Shouldn't the same check for level type be applied for SMT as well? […]
Added an assert for SMT, SDM states sub-leaf index 0 enumerates SMT level.