Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79740?usp=email )
Change subject: driver/wifi: DDR RFIM _DSM method function 3 report incorrect value ......................................................................
driver/wifi: DDR RFIM _DSM method function 3 report incorrect value
The DDR RFIM _DSM method function 3 need to return:
- 0: Enable DDR RFIM feature. - 1: Disable DDR RFIM feature.
BUG=b:302084312 TEST=Build, dump SSDT to check _DSM function 3 return value
Change-Id: I642c56a9c3160cdb41b254dc75e126cacf905b14 Signed-off-by: Simon Yang simon1.yang@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/79740 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Rex Chou rex_chou@compal.corp-partner.google.com --- M src/drivers/wifi/generic/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Eric Lai: Looks good to me, approved Rex Chou: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index f55fca7..f37a084 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -144,7 +144,7 @@ static void wifi_dsm_ddrrfim_func3_cb(void *ptr) { const bool is_cnvi_ddr_rfim_enabled = *(bool *)ptr; - acpigen_write_return_integer(is_cnvi_ddr_rfim_enabled ? 1 : 0); + acpigen_write_return_integer(is_cnvi_ddr_rfim_enabled ? 0 : 1); }
static void (*wifi_dsm_callbacks[])(void *) = {