Attention is currently required from: Johannes Hahn, Mario Scheithauer, Uwe Poeche, Werner Zeh.
Paul Menzel has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86424?usp=email )
Change subject: src/mainboard/siemens/fa_ehl: Configure LPDDR4 initialization ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86424/comment/732c5c58_f3922be7?usp... : PS5, Line 9: KConfig Kconfig
https://review.coreboot.org/c/coreboot/+/86424/comment/6752de69_84984aa9?usp... : PS5, Line 10: Nanya_NT6AP512T32BV-J1I.spd.hex How was this created?
https://review.coreboot.org/c/coreboot/+/86424/comment/41e29f3d_d7d36bb4?usp... : PS5, Line 12: confiugration configuration
https://review.coreboot.org/c/coreboot/+/86424/comment/6da6bd68_c2bc8657?usp... : PS5, Line 12: Additional Additional*ly*
File src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig:
https://review.coreboot.org/c/coreboot/+/86424/comment/bf9be2a2_7365e3c6?usp... : PS5, Line 10: select USE_SIEMENS_HWILIB Please make this a separate commit.
File src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c:
https://review.coreboot.org/c/coreboot/+/86424/comment/b8cecaaa_b7f82584?usp... : PS5, Line 4: #include <gpio.h> Please make this a separate commit.