Attention is currently required from: Tony Huang, Wisley Chen. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55181 )
Change subject: mb/google/dedede/var/drawcia: Add LTE modem support for drawper ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/55181/comment/5f7af907_07af0966 PS3, Line 19: /* A10 : WWAN_EN */ : PAD_CFG_GPO(GPP_A10, 1, PWROK), : : /* B7 : PCIE_CLKREQ2_N ==> WWAN_SAR_DETECT_ODL*/ : PAD_CFG_GPO(GPP_B7, 1, DEEP), : : /* C12 : AP_PEN_DET_ODL has an external pull-up and hence no pad termination.*/ : PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, NONE, DEEP), : : /* D0 : WWAN_HOST_WAKE ==> WWAN_WDISABLE_L */ : PAD_CFG_GPO(GPP_D0, 1, DEEP), : : /* H0 : WWAN_PERST */ : PAD_CFG_GPO(GPP_H0, 0, PLTRST), If this applies only for Drawper, then it is better to configure these gpios only for that using fw_config.
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55181/comment/64d18d98_452a786d PS3, Line 146: chip drivers/usb/acpi : register "desc" = ""LTE"" : register "type" = "UPC_TYPE_INTERNAL" : register "has_power_resource" = "1" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0)" : register "reset_off_delay_ms" = "20" : register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" : register "enable_delay_ms" = "20" : device usb 2.3 on end : end I am afraid this will always show as LTE in all Draw*.