Change in coreboot[master]: soc/intel/icelake: Select CPU_INTEL_COMMON

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

soc/intel/icelake: Select CPU_INTEL_COMMON

This is necessary to show the prompt for ENABLE_VMX, whose value is
written to a FSP UPD. Otherwise, it is always set to zero.

Drop CPU_INTEL_COMMON_SMM since CPU_INTEL_COMMON enables it by default.

Tested with BUILD_TIMELESS=1: Without including the config file in the
coreboot.rom and ENABLE_VMX not selected, the resulting binary remains
identical. Selecting ENABLE_VMX changes a single byte from 0x00 to 0x01.

Change-Id: I9b0ca209b60f9804b8f56497046eff96da01cb5c
Signed-off-by: Angel Pons 
---
M src/soc/intel/icelake/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/45037/1

diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig
index 1230675..2aeb6d6 100644
--- a/src/soc/intel/icelake/Kconfig
+++ b/src/soc/intel/icelake/Kconfig
@@ -15,6 +15,7 @@
    select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH
    select BOOT_DEVICE_SUPPORTS_WRITES
    select CACHE_MRC_SETTINGS
+	select CPU_INTEL_COMMON
    select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
    select FSP_M_XIP
    select GENERIC_GPIO_LIB
@@ -34,7 +35,6 @@
    select FSP_PEIM_TO_PEIM_INTERFACE
    select REG_SCRIPT
    select PMC_GLOBAL_RESET_ENABLE_LOCK
-	select CPU_INTEL_COMMON_SMM
    select SOC_INTEL_COMMON
    select SOC_INTEL_COMMON_ACPI_WAKE_SOURCE
    select SOC_INTEL_COMMON_BLOCK

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1:

does icelake support VMX ?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1:
> Patch Set 1:
>
> does icelake support VMX ?

icelake uses the ENABLE_VMX symbol, but it's not visible unless CPU_INTEL_COMMON is selected

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45037/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45037/1//COMMIT_MSG@9 
PS1, Line 9: to show the prompt for ENABLE_VMX
It also shows the prompt for SET_IA32_FC_LOCK_BIT. But it's not hooked
up. If applicable, set_feature_ctrl_lock() should be called.

This either needs more work/investigation or more fine-grained control
of the prompts.

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1: Code-Review+2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45037/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45037/1//COMMIT_MSG@9 
PS1, Line 9: to show the prompt for ENABLE_VMX
> It also shows the prompt for SET_IA32_FC_LOCK_BIT. But it's not hooked […]

adding set_vmx_and_lock() to soc_core_init(), as done in the other socs *should* be enough. (btw. it's missing in tgl,jsl,elh too)

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45037/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45037/1//COMMIT_MSG@9 
PS1, Line 9: to show the prompt for ENABLE_VMX
> adding set_vmx_and_lock() to soc_core_init(), as done in the other socs *should* be enough. (btw. […]

see CB:31928 for how it was done in CNL

[Michael Niewöhner (Code Review)]

Michael Niewöhner has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Removed Code-Review+2 by Michael Niewöhner

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Patch Set 1: Code-Review-2

This needs a rebase before submission.

[Angel Pons (Code Review)]

Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Removed Code-Review-2 by Angel Pons

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45037 )

Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................

Abandoned

I cannot verify this, and have no intention to do so.