Change in coreboot[master]: soc/intel/tigerlake: select correct chipset based on soc Kconfig
Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37273 )
Change subject: soc/intel/tigerlake: select correct chipset based on soc Kconfig ......................................................................
soc/intel/tigerlake: select correct chipset based on soc Kconfig
Since we accomodate both Tigerlake and Jasperlake soc in single folder, we need to select IFD chipset correctly based on soc.
Change-Id: I73cfe4f583da3a28c3b29d29a93ff62097130e27 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/37273/1
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 01ce7d8..5c17b208 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -96,7 +96,8 @@
config IFD_CHIPSET string - default "tgl" + default "tgl" if SOC_INTEL_TIGERLAKE + default "jsl" if SOC_INTEL_JASPERLAKE
config IED_REGION_SIZE hex
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37273 )
Change subject: soc/intel/tigerlake: select correct chipset based on soc Kconfig ......................................................................
Patch Set 1: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37273 )
Change subject: soc/intel/tigerlake: select correct chipset based on soc Kconfig ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37273 )
Change subject: soc/intel/tigerlake: select correct chipset based on soc Kconfig ......................................................................
soc/intel/tigerlake: select correct chipset based on soc Kconfig
Since we accomodate both Tigerlake and Jasperlake soc in single folder, we need to select IFD chipset correctly based on soc.
Change-Id: I73cfe4f583da3a28c3b29d29a93ff62097130e27 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37273 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Aamir Bohra: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index d767710..652c3a3 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -97,7 +97,8 @@
config IFD_CHIPSET string - default "tgl" + default "tgl" if SOC_INTEL_TIGERLAKE + default "jsl" if SOC_INTEL_JASPERLAKE
config IED_REGION_SIZE hex
-
Aamir Bohra (Code Review) -
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)