Robert Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update ......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xbw, but skipped by return.
BUG=b:376828839 BRANCH=firmware-dedede-13606.B TEST=emerge-dedede coreboot chromeos-bootimage
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a Signed-off-by: Robert Chen robert.chen@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/variants/drawcia/ramstage.c 1 file changed, 14 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/1
diff --git a/src/mainboard/google/dedede/variants/drawcia/ramstage.c b/src/mainboard/google/dedede/variants/drawcia/ramstage.c index aed160e..f7c07c9 100644 --- a/src/mainboard/google/dedede/variants/drawcia/ramstage.c +++ b/src/mainboard/google/dedede/variants/drawcia/ramstage.c @@ -10,25 +10,32 @@ static void ext_vr_update(void) { struct soc_intel_jasperlake_config *cfg = config_of_soc(); + if (fw_config_probe(FW_CONFIG(EXT_VR, EXT_VR_ABSENT))) cfg->disable_external_bypass_vr = 1; }
-void variant_devtree_update(void) +static void update_lte_device_drawper(void) { - uint32_t board_version = board_id(); struct device *lte_usb2 = DEV_PTR(lte_usb2); struct drivers_usb_acpi_config *config; struct acpi_gpio lte_reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0);
- /* board version 9 is drawper EVT */ - if (board_version > 9) - return; - if (lte_usb2 == NULL) return;
config = config_of(lte_usb2); config->reset_gpio = lte_reset_gpio; - ext_vr_update(); +} + +void variant_devtree_update(void) +{ + uint32_t board_version = board_id(); + + if(board_version > 0xb) + ext_vr_update(); + /* Remove power IC after board version 0xc */ + if (board_version <= 0x9) + update_lte_device_drawper(); + /* board version 9 is drawper EVT */ }