Attention is currently required from: Julius Werner, Kyösti Mälkki, Rob Barnes, Patrick Rudolph, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59321 )
Change subject: treewide: Replace spinlock calls with mutex ......................................................................
Patch Set 6:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59321/comment/b4bce879_87484279 PS5, Line 22:
I think printk() is exactly where you would want to yield in romstage for DMA performance, and that […]
I would really prefer to keep printk functional in the threading code. it makes debugging way easier.
I decided to replace all the spinlock usages because it's just a ticking timebomb. I tracked the code again and found a udelay in the smm relocation path. So instead of special casing that one and adding a coop_enable/disable I thought it cleaner to just replace them all.
File src/cpu/intel/microcode/microcode.c:
https://review.coreboot.org/c/coreboot/+/59321/comment/f42da968_790c4c16 PS5, Line 14: struct mutex microcode_lock;
static
Done
File src/cpu/x86/lapic/lapic_cpu_init.c:
https://review.coreboot.org/c/coreboot/+/59321/comment/0d9f87af_cb16b781 PS5, Line 218: struct mutex start_cpu_lock;
static
Done
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/59321/comment/9bc52218_8652a342 PS5, Line 662: struct mutex smm_relocation_lock;
static
Done
File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/59321/comment/ca4e5f48_b80fe090 PS5, Line 74: struct mutex dev_lock;
static
Done
File src/drivers/pc80/rtc/post.c:
https://review.coreboot.org/c/coreboot/+/59321/comment/3c4424b9_d7e9d6be PS5, Line 38: struct mutex cmos_post_lock;
static
Done
-
Raul Rangel (Code Review)