Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86392?usp=email )
Change subject: mb/google/nissa: Add system type selection for Chromebox devices ......................................................................
mb/google/nissa: Add system type selection for Chromebox devices
For Chromebox devices based on the Nissa baseboard, SYSTEM_TYPE_LAPTOP should not be selected. Introduce a new configuration option to allow proper selection for Chromebox devices and select it for dirks variant.
BUG=b:389391653 TEST=emerge-nissa coreboot check CONFIG_CSE_RESET_CLEAR_EC_AP_IDLE_FLAG=y check CONFIG_CR50_RESET_CLEAR_EC_AP_IDLE_FLAG=y
Change-Id: Iabc9afdfdb07d4d6cb4d3fb4b43bfdc3cf2aa383 Signed-off-by: Ivy Jian ivy.jian@quanta.corp-partner.google.com --- M src/mainboard/google/brya/Kconfig 1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/86392/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 58b8922..2e14433 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -97,7 +97,7 @@ select SOC_INTEL_ALDERLAKE_PCH_N select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW select SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE - select SYSTEM_TYPE_LAPTOP + select SYSTEM_TYPE_LAPTOP if !SYSTEM_TYPE_CHROMEBOX select TPM_GOOGLE_TI50 select SOC_INTEL_COMMON_MMC_OVERRIDE
@@ -223,6 +223,7 @@ config BOARD_GOOGLE_DIRKS select BOARD_GOOGLE_BASEBOARD_NISSA select SOC_INTEL_TWINLAKE + select SYSTEM_TYPE_CHROMEBOX
config BOARD_GOOGLE_DOCHI select BOARD_GOOGLE_BASEBOARD_BRYA @@ -714,6 +715,13 @@ select SOC_INTEL_COMMON_BLOCK_IPU select SOC_INTEL_RAPTORLAKE
+if BOARD_GOOGLE_BASEBOARD_NISSA + +config SYSTEM_TYPE_CHROMEBOX + def_bool n + +endif # BOARD_GOOGLE_BASEBOARD_NISSA + if BOARD_GOOGLE_BRYA_COMMON
config BASEBOARD_DIR