Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56700 )
Change subject: soc/amd/common/block/gpio_banks/gpio: use gpio_t for GPIO numbers ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Maybe change gpio_read32() and _write32() to accept gpio_t ahead of this patch?
IIRC I didn't do that since gpio_t is defined in gpio_banks.h and including that in acpimmio.h would be a bit unexpected. I do agree that it would be good if the functions use the correct parameter type though. Would moving the register access functions from acpimmio.h to the common gpio.c be a good idea? In general the GPIO part of acpimmio.h seems a bit odd to me, since it does more than just the raw register access. Would probably be a good idea to try to untangle things a bit more there and also make the common i2c code use some helper functions from gpio.c instead of directly accessing the GPIO registers