Attention is currently required from: Keith Hui, Branden Waldner, Arthur Heymans, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59693 )
Change subject: nb/intel/i440bx: Use PARALLEL_MP ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59693/comment/602de902_beaf0b79 PS4, Line 10: always This is not true, see `src/mainboard/asus/p2b/Kconfig`. Although the CPUs only have one core, there are mainboards with two CPU sockets.
https://review.coreboot.org/c/coreboot/+/59693/comment/50f8c7ed_53351fa3 PS4, Line 13: increase is increased
File src/northbridge/intel/i440bx/northbridge.c:
https://review.coreboot.org/c/coreboot/+/59693/comment/8f56c3f2_cc9baaf8 PS4, Line 6: #include <device/device.h> I wouldn't remove this, `struct device` is used
https://review.coreboot.org/c/coreboot/+/59693/comment/1cfb49f9_4b469fb6 PS4, Line 76: 1 Not true for mainboards with two CPU sockets, see comment in commit message.
I'm not sure if there's a generic procedure to detect which CPU sockets are populated. In any case, returning `CONFIG_MAX_CPUS` would at least be slightly more correct.
-
Angel Pons (Code Review)