Attention is currently required from: Keith Hui, Branden Waldner, Arthur Heymans, Patrick Rudolph.
Patch set 4:Code-Review +1
4 comments:
Commit Message:
Patch Set #4, Line 10: always
This is not true, see `src/mainboard/asus/p2b/Kconfig`. Although the CPUs only have one core, there are mainboards with two CPU sockets.
Patch Set #4, Line 13: increase
is increased
File src/northbridge/intel/i440bx/northbridge.c:
Patch Set #4, Line 6: #include <device/device.h>
I wouldn't remove this, `struct device` is used
Not true for mainboards with two CPU sockets, see comment in commit message.
I'm not sure if there's a generic procedure to detect which CPU sockets are populated. In any case, returning `CONFIG_MAX_CPUS` would at least be slightly more correct.
To view, visit change 59693. To unsubscribe, or for help writing mail filters, visit settings.