Attention is currently required from: Nico Huber, Paul Menzel.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76997?usp=email )
Change subject: mb/roda/rv11: Post-Haswell cleanup ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76997/comment/dba3a4e6_319c8551 : PS1, Line 7: mb/roda/rv11: Post-Haswell cleanup
A more specific summary would be nice (also written as statement by adding a verb in imperative mood […]
That kind of summary could be too long. It carries 3 clean up items. A cue to split?
Patchset:
PS1: Also this train is meant to be review and committed in stages. I marked WIP the patch where each stage begins. It means this one will come much later.
File src/mainboard/roda/rv11/variants/rw11/early_init.c:
https://review.coreboot.org/c/coreboot/+/76997/comment/9b41bad3_456795db : PS1, Line 9: // include <northbridge/intel/sandybridge/sandybridge.h>
Remove the whole line?
Yes, I should have done so. Will address in next patch set.
-
Keith Hui (Code Review)